<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122331/">https://git.reviewboard.kde.org/r/122331/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 12th, 2015, 7:22 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The commit seems to have missed backends/x11/libinputproperties.c, it now fails to build for me:
CMake Error at src/CMakeLists.txt:48 (add_library):
Cannot find source file:
backends/x11/libinputproperties.c</pre>
</blockquote>
<p>On February 12th, 2015, 7:29 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Extracted from review request, and pushed separately in commit e267c5fd548198b4cbc064168191c13777ea54d0</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks!
I've no clue how that file got missed. My usual testing (build rpm) did succeed...</p></pre>
<br />
<p>- Rajeesh</p>
<br />
<p>On February 12th, 2015, 6:34 p.m. UTC, Rajeesh K Nambiar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Alexander Mezin and Martin Gräßlin.</div>
<div>By Rajeesh K Nambiar.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2015, 6:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcm-touchpad
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ibinput is a library to handle input devices in Wayland compositors and to provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
Patch authored by Peter Hutterer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fedora 21 RPM built and tested with Plasma 5.2.
RPMs available here for testing: https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcm/touchpad.kcfg <span style="color: grey">(2afe642)</span></li>
<li>src/kcm/ui/tap.ui <span style="color: grey">(8e081ad)</span></li>
<li>src/touchpadbackend.cpp <span style="color: grey">(93e3dc2)</span></li>
<li>src/backends/x11.cmake <span style="color: grey">(f208281)</span></li>
<li>src/backends/x11/libinputproperties.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/x11/synclientproperties.h <span style="color: grey">(5b32b9f)</span></li>
<li>src/backends/x11/xlibbackend.h <span style="color: grey">(3692a60)</span></li>
<li>src/backends/x11/xlibbackend.cpp <span style="color: grey">(3b5e5be)</span></li>
<li>src/kcm/customconfigdialogmanager.cpp <span style="color: grey">(75b03ab)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122331/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>