<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122505/">https://git.reviewboard.kde.org/r/122505/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 10th, 2015, 9:01 a.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not quite sure if a user wants to see a warning message at all.
When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook).</p></pre>
</blockquote>
<p>On February 10th, 2015, 9:18 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I stated above, "all the way down" can mean "completely off", which I wouldn't expect as a user. I've never seen any other device that does that, apart from some black and white seven-segment display calculators.</p></pre>
</blockquote>
<p>On February 10th, 2015, 9:22 a.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Then it's device specific even!
- My notebook: all the way down = still visible
- My macbook: all the way down = off</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you detect that?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You message does make sense if the lowest step = off. It doesn't if the lowest step is still on.</p></pre>
</blockquote>
<p>On February 10th, 2015, 9:47 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that this is only for when you are dragging it by mouse - if you drag it all the way down and your screen goes black, there's no way to recover if your keys don't work. If your keys work and stuff, you probably never use the slider, so this for a minority of users. It's the same reason we ask confirmation when deleting a file.</p></pre>
</blockquote>
<p>On February 10th, 2015, 9:23 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wait wait wait wait... Could it be that we've come up with an overly complex solution to a rather simple problem?
Actually, those devices which turn the backlight off at 0% brightness are the only ones doing it <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">right</em>. I always found it very weird when my screen brightness OSD said "0%" but I could still see things. 0% brightness means zero brightness means <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">dark</em>.
So why should the user even be able to set the brightness to 0% anyway?
Since turning off the backlight without turning off the screen doesn't make sense practically, there just should be no way for the user to set the brightness to 0%, period.
So let the slider start at 1% and don't allow the brightness to go zero neither via power management nor via brightness keys.
That solves two problems: Accidentally setting to zero <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">and</em> that semantic bullshit of "0% brightness but I can still see stuff".</p></pre>
</blockquote>
<p>On February 10th, 2015, 9:50 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So why should the user even be able to set the brightness to 0% anyway?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To save battery time when the screen is not needed <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">right now</em>, perhaps? I quite often compile things on my laptop when on battery, this can take up to 5 minutes and it's already quite a battery drainer, why the screen backlight should help it when it's not needed? I listen to music while cooking, screen backlight not needed. Etc etc.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So let the slider start at 1% and don't allow the brightness to go zero neither via power management nor via brightness keys.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I disagree there. It's a hardware design after all, there's no reason the software couldn't/shouldn't take advantage of that. Also setting it to 1% does not really make a difference (not on my laptop at least), it's so dark it's useless, so I'd have to be higher, like 5% or 10%, which is...weird, I think.</p></pre>
</blockquote>
<p>On February 10th, 2015, 10:01 p.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Quote: "So let the slider start at 1% and don't allow the brightness to go zero neither via power management nor via brightness keys."</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please, no! I don't really care if 0% is a hardware flaw or design. We apparently are stuck with the fact that we have hardware behaving differently. The software should not limit prevent me to use my hardware at it's full capacity. If 0% in my case is still visible then so be it and that should be allowed just fine. If you forbid this then i expect quite some bug reports for that will flow in.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If you want 0% to be off then you should buy hardware that obeys that.</p></pre>
</blockquote>
<p>On February 10th, 2015, 10:04 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To save battery time when the screen is not needed right now, perhaps?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Turning the screen off when it's not in use is a perfectly useful thing to do, but that is <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not</em> what a brightness slider is for. The brightness slider is there to allow users to set the optimum brightness for their current surroundings.
Check out your mobile phone or tablet. Regardless of which OS it runs, I am very confident that pushing the slider all the way to the left will <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not</em> turn off the backlight.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With a sensible power setting, the screen will turn off after some idle period when on battery anyway. If we want to allow the user to turn it off manually, there should be a keyboard shortcut for it. It <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">must not</em> be a button in the GUI, because then there would be now way to turn it on again because you could not see it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Turning off the screen via brightness slider doesn't only have the problem this patch is supposed to solve, but also the disadvantage that you have to find your optimal brightness setting again afterwards. If the screen is turned off by a shortcut or via power management, it should return to the previous brightness setting again after it's turned on again.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also setting it to 1% does not really make a difference (not on my laptop at least), it's so dark it's useless, so I'd have to be higher, like 5% or 10%, which is...weird, I think.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's why other OSes display percentages but only graphical representations of relative britghness. Which makes sense given that the same percentage of brightness means very different things with different hardware.</p></pre>
</blockquote>
<p>On February 10th, 2015, 10:06 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Btw. sometimes it's (just) a driver issue, if you're on Intel, try adding</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Section <span style="color: #BA2121">"Device"</span>
Driver <span style="color: #BA2121">"intel"</span>
Option <span style="color: #BA2121">"Backlight"</span> <span style="color: #BA2121">"intel_backlight"</span>
EndSection
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">to your xorg.conf (or equivalent), then you should get 0% == backlight off. Similar is with nvidia binary, that requires</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Option <span style="color: #BA2121">"RegistryDwords"</span> <span style="color: #BA2121">"EnableBrightnessControl=1"</span>
</pre></div>
</p></pre>
</blockquote>
<p>On February 10th, 2015, 10:13 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am very confident that pushing the slider all the way to the left will not turn off the backlight.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But you also don't have dedicated keys to control brightness like you do on laptop. How else would you turn in on if you've turned it off? On laptop, you have dedicated keys. If you try to turn it off using the slider, it warns you. Seems pretty sensible to me. Plus, on mobile phone you have a dedicated button to turn off your screen right now. I don't think many laptops have that same dedicated key...?</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but also the disadvantage that you have to find your optimal brightness setting again afterwards.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I'm skilled enough to turn my brightness off, I'm also skilled enough to find my optimal brigthness. This honestly is a non-issue, it could as well be used ad-absurdum to disallow the users any brightness changes at all.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there should be a keyboard shortcut for it</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We already do have rather simple way for it, 0% brightness means no brightness (as far as drivers allow). It's that simple. Why should the user learn another shortcut? (which would be just as undiscoverable as say krunner).</p></pre>
</blockquote>
<p>On February 10th, 2015, 10:29 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But you also don't have dedicated keys to control brightness like you do on laptop. How else would you turn in on if you've turned it off? On laptop, you have dedicated keys. If you try to turn it off using the slider, it warns you. Seems pretty sensible to me.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See, the problem is that we allow users to switch off the screen via GUI but they don't have a way to turn it on again via GUI (because, you know, they can't see squat). That makes zero sense.
If we allow users only to turn it off via keyboard, they can turn it on again via keyboard. Everything is fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If a user doesn't have keys to turn the screen on again, it can only turn off via power management, which means it will turn on again on any input. Everything is fine.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We already do have rather simple way for it, 0% brightness means no brightness (as far as drivers allow). It's that simple. Why should the user learn another shortcut? (which would be just as undiscoverable as say krunner).</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe I see what you're getting at: How about allowing setting brightness to 0 (= off) via keyboard brightness controls (because that way it can be turned on again as well) but not via the slider?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is a rule in design for safety:
1. Prevent users from performing a dangerous action
2. If 1. is not possible, use a warning</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This rule exists because warnings are never 100% safe, so they can only ever be "better than nothing".</p></pre>
</blockquote>
<p>On February 10th, 2015, 11:02 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I'm skilled enough to turn my brightness off, I'm also skilled enough to find my optimal brigthness. This honestly is a non-issue, it could as well be used ad-absurdum to disallow the users any brightness changes at all.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I meant that more as an argument for the convenience of having a way to directly turn off the screen instead of setting the brightness all the way to zero. It's exactly the same thing as with "mute" functions on volume controls. They do the same as setting the volume to zero, but
a) It's quicker
b) You get your previous volume setting back after un-muting</p></pre>
</blockquote>
<p>On February 10th, 2015, 11:12 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But note that 0% volume also means "turning off" (muting) and in that sense I see those two actions very similar. But yeah 0% volume is not as "destructive" as 0% brightness can be.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How about allowing setting brightness to 0 (= off) via keyboard brightness controls (because that way it can be turned on again as well) but not via the slider?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, that's what Kai is getting at - keyboard controls should remain unaffected, but if you try lowering brightness to 0% using a slider, it will stop you at a sensible low value and issue a warning. If the user still insists, then, well, his bad luck. But maybe the slider simply could have a hard limit, plus the warning saying to use brigthness keys instead.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also had an idea to detect during a running session if brightness keys work and then just skip the warning step altogether as Plasma would know that recovery by keyboard is possible...but just a 2c idea.</p></pre>
</blockquote>
<p>On February 11th, 2015, 9:41 a.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think many laptops have that same dedicated key...?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Most laptops I know have dedicated buttons to turn the screen off/on.</p></pre>
</blockquote>
<p>On February 11th, 2015, 10:03 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Most laptops have dedicated buttons to switch screen outputs (which is not dedicated button to turn brightness off). Just google image search for "laptop keyboard" and have a look.</p></pre>
</blockquote>
<p>On February 11th, 2015, 10:27 a.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">which is not dedicated button to turn brightness off</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks but I know the difference between switching and turning off/on screens ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">4 different notebooks (asus and lenovo) here and 3 of them have a dedicated buttons to turn the screen off and on again. (e.g. http://goo.gl/3CLDGP Fn+F6)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">... let us get back to the original discussion ;)</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also had an idea to detect during a running session if brightness keys work and then just skip the warning step altogether</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I may chime in, I have an alternate proposal.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why not have two behaviours;
- Have the minimum value of the slider be 1.
- Have the minimum value of keys be 0.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Essentially, if you are using the screen, we can't rely on the user having (or knowing) about brightness keys; since the user is relying on the screen for control, the screen-based controls should not be capable of hiding themselves. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If the user is activly using hardware keys - then it's a safe to turn it to 0.</p></pre>
<br />
<p>- Ken</p>
<br />
<p>On February 9th, 2015, 10:25 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2015, 10:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some graphics drivers, notably Intel, turn off the backlight completely when brightness reached zero, which is also in the spec (0 = off, 1 = very dim) but imho that's unexpected. To prevent the user from accidentally turnign the screen off, especially when keyboard brightness controls don't work, which sadly still happens quite often, the slider breaks free from the user's drag (by becoming disable for two (perhaps 1 is enough?) seconds, so we also catch the mouse wheel case) and displays a warning (which stays there until screen brightness is dialed up again).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works pretty well, I just realized I forgot the mousewheel-on-trayicon case. Also, I'm open to wording suggestions since it sounds more like "we suck, sorry about that". (Note in the screenshot I used the mouse wheel, hence the displayed 4% rather than 5)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/batterymonitor/package/contents/ui/BrightnessItem.qml <span style="color: grey">(546ab58)</span></li>
<li>applets/batterymonitor/package/contents/ui/PopupDialog.qml <span style="color: grey">(a2acf31)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122505/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/8b585088-e33e-4862-9c46-207d06f566f1__dimwarning.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>