<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122524/">https://git.reviewboard.kde.org/r/122524/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 11th, 2015, 2:25 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122524/diff/1/?file=348257#file348257line33" style="color: black; font-weight: bold; text-decoration: underline;">components/shellprivate/widgetexplorer/widgetexplorer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KServiceTypeTrader></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this still needed?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">right, widgetsMenuActions() is still not really ported, still have to finish that</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 11th, 2015, 2:25 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122524/diff/1/?file=348299#file348299line42" style="color: black; font-weight: bold; text-decoration: underline;">shell/scripting/scriptengine.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <Plasma/PluginLoader></span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <Plasma/PluginLoader></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This include can go away, I suppose.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there as well is still using pluginloader::listcontainmentsoftype that's fine</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On February 11th, 2015, 1:44 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2015, 1:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this is the branch mart/KPackage.
it ports away the various stuff (shell, krunner, screenlocker.. ) using Plasma::Package to KPackage directly
the widget explorer/alternatives is also ported away from sycoca, using the new kpackage cache mechanism to query for applets</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/packageplugins/qmlWallpaper/CMakeLists.txt <span style="color: grey">(cc6ece1)</span></li>
<li>shell/packageplugins/qmlWallpaper/plasma-packagestructure-wallpaper.desktop <span style="color: grey">(48a6d52)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.h <span style="color: grey">(a8a1f52)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.cpp <span style="color: grey">(50beeb2)</span></li>
<li>shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop <span style="color: grey">(f870e0d)</span></li>
<li>components/shellprivate/interactiveconsole/interactiveconsole.cpp <span style="color: grey">(662e3de)</span></li>
<li>components/shellprivate/widgetexplorer/openwidgetassistant.cpp <span style="color: grey">(ed1d0e3)</span></li>
<li>components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp <span style="color: grey">(42422d1)</span></li>
<li>components/shellprivate/widgetexplorer/widgetexplorer.cpp <span style="color: grey">(a739a17)</span></li>
<li>dataengines/share/packagestructure/CMakeLists.txt <span style="color: grey">(9a8a8dd)</span></li>
<li>dataengines/share/packagestructure/share_package.h <span style="color: grey">(31d0f6f)</span></li>
<li>dataengines/share/packagestructure/share_package.cpp <span style="color: grey">(bd8567e)</span></li>
<li>dataengines/share/shareservice.h <span style="color: grey">(8f6aa76)</span></li>
<li>dataengines/share/shareservice.cpp <span style="color: grey">(2529878)</span></li>
<li>krunner/view.cpp <span style="color: grey">(9d33fe5)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: grey">(84a8aa3)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: grey">(14a34f0)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: grey">(4a90faf)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(824ba60)</span></li>
<li>ksmserver/screenlocker/kcm/CMakeLists.txt <span style="color: grey">(41e04c9)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.h <span style="color: grey">(6741e47)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.cpp <span style="color: grey">(28f5e35)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(1c00f19)</span></li>
<li>ksplash/ksplashqml/CMakeLists.txt <span style="color: grey">(16c58a0)</span></li>
<li>ksplash/ksplashqml/SplashWindow.cpp <span style="color: grey">(807dc9b)</span></li>
<li>plasma-windowed/plasmawindowedcorona.cpp <span style="color: grey">(8096f9c)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(cb48ab8)</span></li>
<li>shell/containmentconfigview.cpp <span style="color: grey">(3ec7efe)</span></li>
<li>shell/desktopview.h <span style="color: grey">(ea9e555)</span></li>
<li>shell/desktopview.cpp <span style="color: grey">(bbe16f2)</span></li>
<li>shell/packageplugins/layouttemplate/CMakeLists.txt <span style="color: grey">(ba85efb)</span></li>
<li>shell/packageplugins/lookandfeel/CMakeLists.txt <span style="color: grey">(68ff00f)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.h <span style="color: grey">(e1c5605)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.cpp <span style="color: grey">(0f7d6d0)</span></li>
<li>shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop <span style="color: grey">(98faa6b)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d9fc33c)</span></li>
<li>shell/packageplugins/qmlWallpaper/wallpaper.h <span style="color: grey">(f3cd5d6)</span></li>
<li>shell/packageplugins/qmlWallpaper/wallpaper.cpp <span style="color: grey">(4aa8c2a)</span></li>
<li>shell/packageplugins/shell/CMakeLists.txt <span style="color: grey">(9b15426)</span></li>
<li>shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop <span style="color: grey">(c001334)</span></li>
<li>shell/packageplugins/shell/shellpackage.h <span style="color: grey">(744e26c)</span></li>
<li>shell/packageplugins/shell/shellpackage.cpp <span style="color: grey">(ad815c1)</span></li>
<li>shell/packageplugins/wallpaperimages/CMakeLists.txt <span style="color: grey">(9acafc8)</span></li>
<li>shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop <span style="color: grey">(6f105d9)</span></li>
<li>shell/packageplugins/wallpaperimages/wallpaperpackage.h <span style="color: grey">(541e1f7)</span></li>
<li>shell/packageplugins/wallpaperimages/wallpaperpackage.cpp <span style="color: grey">(9231bce)</span></li>
<li>shell/scripting/scriptengine.cpp <span style="color: grey">(ceb7afc)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(3321adf)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(187b68c)</span></li>
<li>shell/standaloneappcorona.cpp <span style="color: grey">(e98499c)</span></li>
<li>wallpapers/image/backgroundlistmodel.h <span style="color: grey">(0fa0d92)</span></li>
<li>wallpapers/image/backgroundlistmodel.cpp <span style="color: grey">(0042c3c)</span></li>
<li>wallpapers/image/image.h <span style="color: grey">(4fb87d2)</span></li>
<li>wallpapers/image/image.cpp <span style="color: grey">(209ed67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122524/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>