<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122452/">https://git.reviewboard.kde.org/r/122452/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2015, 10:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Emitting dbus signals allows interested parties to be notified about
OSD changes. E.g. the lock screen might want to show the OSD values,
but blocks the actual OSD, so it needs to be informed about changes
to react on them.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[lookandfeel] Split mainItem of Osd into a dedicated OsdItem</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Allows to reuse the content of the Osd in other parts without
having it to be a Dialog.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[screenlocker] Support OnScreenDisplay messages</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KSld connects to the DBus signals for the OnScreenDisplay and forwards
them to the greeter application through the private Wayland protocol.
The idea here is to not have the greeter connect to the DBus as in future
it would be preferable if the greeter cannot connect to DBus.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The lookandfeel package might expose an object called "onScreenDisplay".
Whenever an OSD message is recieved by the greeter it looks for such an
object and updates the osd specific properties.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The default breeze lookandfeel package integrates the OsdItem from the
same lookandfeel package.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: grey">(4a90fafee810940c3f932c8e2bfed10459adc425)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(a23b5625adc99661ab07534403ee23d005581c03)</span></li>
<li>ksmserver/screenlocker/protocols/ksld.xml <span style="color: grey">(bfb32190bf2529a14b39fac4c7e6029a5df811d0)</span></li>
<li>ksmserver/screenlocker/waylandserver.h <span style="color: grey">(5a8ed2249152277b505fe7a944b1b7251ef995d3)</span></li>
<li>ksmserver/screenlocker/waylandserver.cpp <span style="color: grey">(746032e1a7b1bad3625b9f0a156de059e5fba31a)</span></li>
<li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: grey">(1c4e4a510dd9196ae2b36bc355490580c06a78a6)</span></li>
<li>lookandfeel/contents/osd/Osd.qml <span style="color: grey">(b63338c2f94c074b405bba5509623ef38eef5350)</span></li>
<li>lookandfeel/contents/osd/OsdItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/osd.h <span style="color: grey">(356b073b2b9c88e57c324701ae47e0e969b75a51)</span></li>
<li>shell/osd.cpp <span style="color: grey">(b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122452/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png">Lock screen with volume OSD</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png">With background</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>