<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122488/">https://git.reviewboard.kde.org/r/122488/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 9th, 2015, 2:21 a.m. CET, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd advice against the new C++ functions. You can use setDisplayDate (even in QML with the displayedDate property) to accomplish the exact same thing and it keeps the C++ API clean.
If you really want to have the "helper functions" on the C++ side then you should call setDisplayDate(...) within those helper functions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But i like your change from a visual perspective :) I actually think John Layt had this on his wish lish for the calendar!
Also, did you notice your bottom border in the month view is missing? It's like that in plasma 5.2 as well.</p></pre>
</blockquote>
<p>On February 9th, 2015, 10:33 a.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added them because the others were there and I didn't figure out how to work with displayedDate, given JS Date is super horrible to work with but I'll take a look.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kai: ...that's been that way for some time for me, though.
Mark: Also, did you notice your bottom border in the month view is missing? It's like that in plasma 5.2 as well.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Guys, please do report these at bko, kinda sucks if we released it like this and nobody shouted about this kinda huge visual bug :S</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On February 8th, 2015, 9:52 p.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2015, 9:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This improves the calendar navigation by providing a "Year overview" showing all 12 months in a grid, and a "Decade overview" showing the current decade in a grid.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/calendar.cpp <span style="color: grey">(a766acb)</span></li>
<li>src/declarativeimports/calendar/daydata.h <span style="color: grey">(39ac086)</span></li>
<li>src/declarativeimports/calendar/daysmodel.h <span style="color: grey">(ec88837)</span></li>
<li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: grey">(1a6f454)</span></li>
<li>src/declarativeimports/calendar/qml/DayDelegate.qml <span style="color: grey">(6a3747e)</span></li>
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: grey">(67b3a2e)</span></li>
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: grey">(6eaa8db)</span></li>
<li>src/declarativeimports/calendar/calendar.h <span style="color: grey">(ea20bf5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122488/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>