<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122420/">https://git.reviewboard.kde.org/r/122420/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122420/diff/2/?file=346883#file346883line153" style="color: black; font-weight: bold; text-decoration: underline;">applets/systemmonitor/common/contents/ui/Applet.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">153</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">Component</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm lost on something.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why do we have a component singleValuePlotter and also SinglePlotter.qml</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">same for twoValuesPlotter and DoublePlotter.qml</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">They seem almost the same yet not quite?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122420/diff/2/?file=346883#file346883line164" style="color: black; font-weight: bold; text-decoration: underline;">applets/systemmonitor/common/contents/ui/Applet.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">164</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">color:</span> <span class="nx">theme</span><span class="p">.</span><span class="nx">highlightColor</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what colour does the Plotter background default to?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's potential for a white on white situation here if we hardcode one value and take one from a theme.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122420/diff/2/?file=346900#file346900line22" style="color: black; font-weight: bold; text-decoration: underline;">applets/systemmonitor/diskactivity/metadata.desktop</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">X-KDE-PluginInfo-EnabledByDefault=true</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not needed * n</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122420/diff/2/?file=346917#file346917line16" style="color: black; font-weight: bold; text-decoration: underline;">klipper/org.kde.plasma.clipboard.operations</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <label>The width of the preview in pixel<span class="hl">s</span></label></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <label>The width of the preview in pixel</label></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this is probably just reviewboard being stupid, but make sure this is in a separate commit</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On February 4th, 2015, 12:26 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2015, 12:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this refactors the net systemmonitor plasmoid (hopefully fixing some of the bugs people had with it)
and brings back some other modules:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> cpu usage
</em> disk i/o activity
* memory usage
All applets share most of their stuff having as little duplication as possible</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(25d774e)</span></li>
<li>applets/systemmonitor/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/Messages.sh <span style="color: grey">(2382ed6)</span></li>
<li>applets/systemmonitor/common/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/Applet.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/DoublePlotter.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/SinglePlotter.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/contents/config/config.qml <span style="color: grey">(11944e5)</span></li>
<li>applets/systemmonitor/contents/config/main.xml <span style="color: grey">(57a30cb)</span></li>
<li>applets/systemmonitor/contents/ui/configGeneral.qml <span style="color: grey">(164e890)</span></li>
<li>applets/systemmonitor/contents/ui/net.qml <span style="color: grey">(20e1d47)</span></li>
<li>applets/systemmonitor/cpu/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/contents/ui/cpu.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/contents/ui/cpuConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/contents/ui/diskusage.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/contents/ui/memory.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/contents/ui/memoryConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/metadata.desktop <span style="color: grey">(00965ab)</span></li>
<li>applets/systemmonitor/net/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/net/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/net/contents/ui/net.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/net/contents/ui/netConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/net/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>klipper/org.kde.plasma.clipboard.operations <span style="color: grey">(5e9f71a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122420/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>