<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122420/">https://git.reviewboard.kde.org/r/122420/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 4th, 2015, 2:31 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code is all fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By default each of these shows nothing; showing everything would be a better default</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The disk usage one doesn't seem to work at all. It's not even remembering the options I select</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's auto scaling the graph CPU and memory between the current max and min and not between 0% and 100%.
So if I'm at 1% then have one second at 3% the graph will show it as being full usage which is confusing.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">uuh weird, it should show everything by default.
Tough it may need a commit of yesterday in KConfig, defaults for stringlist config keys was wrong, was one list containing an empty string instead of an empty list. with that one it <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">should</em> behave correctly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For the max and min, it will require some api addition in the plotter component (autorange can already be enabled or disabled, but the maximum and minimum range values are not writable yet)</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On February 4th, 2015, 2:10 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2015, 2:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this refactors the net systemmonitor plasmoid (hopefully fixing some of the bugs people had with it)
and brings back some other modules:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> cpu usage
</em> disk i/o activity
* memory usage
All applets share most of their stuff having as little duplication as possible</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemmonitor/net/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>klipper/org.kde.plasma.clipboard.operations <span style="color: grey">(5e9f71a)</span></li>
<li>applets/systemmonitor/net/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/net/contents/ui/net.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/net/contents/ui/netConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/contents/ui/diskusage.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskusage/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/contents/ui/memory.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/contents/ui/memoryConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/memory/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/metadata.desktop <span style="color: grey">(00965ab)</span></li>
<li>applets/systemmonitor/net/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(25d774e)</span></li>
<li>applets/systemmonitor/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/Messages.sh <span style="color: grey">(2382ed6)</span></li>
<li>applets/systemmonitor/common/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/Applet.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/DoublePlotter.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/common/contents/ui/SinglePlotter.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/contents/config/config.qml <span style="color: grey">(11944e5)</span></li>
<li>applets/systemmonitor/contents/config/main.xml <span style="color: grey">(57a30cb)</span></li>
<li>applets/systemmonitor/contents/ui/configGeneral.qml <span style="color: grey">(164e890)</span></li>
<li>applets/systemmonitor/contents/ui/net.qml <span style="color: grey">(20e1d47)</span></li>
<li>applets/systemmonitor/cpu/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/contents/ui/cpu.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/contents/ui/cpuConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/cpu/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemmonitor/diskactivity/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122420/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>