<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122065/">https://git.reviewboard.kde.org/r/122065/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72" style="color: black; font-weight: bold; text-decoration: underline;">src/service/ksmserver/KSMServer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KSMServer::Private::serviceOwnerChanged(const QString &service,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kwin</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QDBusInterface</span><span class="p">(</span><span class="n">KWIN_SERVICE</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"/KWin"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"org.kde.<span class="hl">kw</span>in"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kwin</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QDBusInterface</span><span class="p">(</span><span class="n">KWIN_SERVICE</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"/KWin"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"org.kde.<span class="hl">KW</span>in"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you add:
- checking for the environment variable existence (and using it, if not empty)
- a TODO with a summary of what was talked about here? (multi-head problems, the need for session management to be reimplemented in some way on waland etc.)</p></pre>
</div>
</div>
<br />
<p>- Ivan Čukić</p>
<br />
<p>On January 27th, 2015, 12:23 a.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Martin Gräßlin and Ivan Čukić.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2015, 12:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">KWin Interface name is wrong</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kactivitymanagerd doesn't listen on ksmserver anymore, thus subSession{Opened,Closed,CloseCanceled} are not called anymore. It need to send Started/Stopped event by itself when kwin dbus call returns.</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now starting and stopping activity works properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/service/ksmserver/KSMServer.cpp <span style="color: grey">(b5e1467)</span></li>
<li>src/service/ksmserver/KSMServer_p.h <span style="color: grey">(c0f5598)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122065/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>