<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122200/">https://git.reviewboard.kde.org/r/122200/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122200/diff/3/?file=344270#file344270line92" style="color: black; font-weight: bold; text-decoration: underline;">src/qmlcontrols/kcoreaddons/formats.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class Formats : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">83</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">Q_INVOKABLE</span> <span class="n">QString</span> <span class="n">formatRelativeDate</span><span class="p">(</span><span class="k">const</span> <span class="n">QDate</span> <span class="o">&</span><span class="n">date</span><span class="p">,</span> <span class="n">QLocale</span><span class="o">::</span><span class="n">FormatType</span> <span class="n">format</span><span class="p">)</span> <span class="k">const</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">Q_INVOKABLE</span> <span class="n">QString</span> <span class="n">formatRelativeDate</span><span class="p">(</span><span class="k">const</span> <span class="n">QDate</span> <span class="o">&</span><span class="n">date</span><span class="p">,</span> <span class="n">QLocale</span><span class="o">::</span><span class="n">FormatType</span> <span class="n">format</span><span class="p">)</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">do these work?</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On January 22nd, 2015, 3:54 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2015, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is currently not possible to use Q_INVOKABLE that takes Q_ENUM/Q_FLAGS as a parameter that is defined in a different class. This is mentioned in the docs and there's also a bug report here - https://bugreports.qt.io/browse/QTBUG-20639</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If the default parameter is removed from the formatDuration, Plasma will complain with "Error: Unknown method parameter type KFormat::DurationFormatOptions".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Until that one is fixed, we can either take an integer and cast it to the flags or redeclare the enum from KFormats locally, but that's just not good.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KFormat now properly formats the remaining time based on the passed flags.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/kcoreaddons/formats.h <span style="color: grey">(59537bf)</span></li>
<li>src/qmlcontrols/kcoreaddons/formats.cpp <span style="color: grey">(256778f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122200/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>