<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121476/">https://git.reviewboard.kde.org/r/121476/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The adjustments look good to me. If we want it for the next plasma release I call it a "ShipIt". If we want to delay by one release the code could be extremely simplified by making use of https://git.reviewboard.kde.org/r/121667/</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On December 19th, 2014, 6:23 p.m. CET, Ashish Madeti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Bhushan Shah, Martin Gräßlin, and Vishesh Handa.</div>
<div>By Ashish Madeti.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2014, 6:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ported the "Show Desktop" applet to Plasma Next.
Most of the code is derived from the old showdesktop applet.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested the applet locally, working fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/showdesktop/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/plasma-applet-showdesktop.desktop <span style="color: grey">(f36a1da)</span></li>
<li>applets/showdesktop/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/plugin/showdesktop.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/plugin/showdesktop.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/plugin/showdesktopplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/plugin/showdesktopplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/showdesktop.h <span style="color: grey">(5aeb848)</span></li>
<li>applets/showdesktop/showdesktop.cpp <span style="color: grey">(d712519)</span></li>
<li>config-kdeplasma-addons.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(db03015)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(ccd1bf7)</span></li>
<li>applets/showdesktop/CMakeLists.txt <span style="color: grey">(eb53207)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121476/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>