<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121790/">https://git.reviewboard.kde.org/r/121790/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121790/diff/1/?file=337757#file337757line576" style="color: black; font-weight: bold; text-decoration: underline;">shell/shellcorona.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int ShellCorona::numScreens() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">572</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">v</span><span class="o">-></span><span class="n">screen</span><span class="p">()</span> <span class="o">==</span> <span class="n">v</span><span class="o">-></span><span class="n">screen</span><span class="p">()</span> <span class="o">&&</span> <span class="n">v</span><span class="o">-></span><span class="n">visibilityMode</span><span class="p">()</span> <span class="o">!=</span> <span class="n">PanelView</span><span class="o">::</span><span class="n">AutoHide</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">550</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">v<span class="hl">iew</span></span><span class="o">-></span><span class="n">screen</span><span class="p">()</span> <span class="o">==</span> <span class="n">v</span><span class="o">-></span><span class="n">screen</span><span class="p">()</span> <span class="o">&&</span> <span class="n">v</span><span class="o">-></span><span class="n">visibilityMode</span><span class="p">()</span> <span class="o">!=</span> <span class="n">PanelView</span><span class="o">::</span><span class="n">AutoHide</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This fixes the panels dancing around btw :D</p></pre>
</div>
</div>
<br />
<p>- Lukáš Tinkl</p>
<br />
<p>On leden 2nd, 2015, 1 odp. CET, Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated Led. 2, 2015, 1 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Drawbacks:
- QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To disable ext screen: xrandr --output HDMI3 --off
To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c6d89c1)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(cb48ab8)</span></li>
<li>shell/panelview.h <span style="color: grey">(d1ef282)</span></li>
<li>shell/panelview.cpp <span style="color: grey">(b7f043d)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(3321adf)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(c26efe5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121790/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>