<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121762/">https://git.reviewboard.kde.org/r/121762/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build with clang 3.4</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clang doesn't allow variable length arrays of non-POD data types
Also it seems that the default template instantion depth is not
enough to compile geometry_parser.cpp</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add missing includes of cmath and cstdlib</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix clang warning -Wmismatched-tags</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build of geometry_parser test with clang</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We need to increase the template instantiation depth</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix more -Wmismatched-tag warnings</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build of kapplymousetheme if X11 isn't installed to /usr</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build of phonon KCM if libcanberra is not in /usr</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/keyboard/bindings.h <span style="color: grey">(d59790752ced2ec8fd77269f75012e74ccda4cc4)</span></li>
<li>kcms/keyboard/flags.h <span style="color: grey">(3957a983f06044e8f5ed130afc4774f8c644ed8c)</span></li>
<li>kcms/keyboard/kcm_add_layout_dialog.h <span style="color: grey">(a2c0ac5ebc264d69555063668cb68be5255b3030)</span></li>
<li>kcms/keyboard/kcm_keyboard.h <span style="color: grey">(c88fe3dd8540df07eb886b3119dfbe30fab2844b)</span></li>
<li>kcms/keyboard/kcm_keyboard_widget.h <span style="color: grey">(5994ea4815d6398afaf6765b77a2bc8cd349f780)</span></li>
<li>kcms/keyboard/kcm_view_models.h <span style="color: grey">(872e26185248c6dfb8d8808115865ae18596cbea)</span></li>
<li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(9aed7de2a8a63aa546dc9484eea0edadcc64ec66)</span></li>
<li>containments/folder/plugin/positioner.cpp <span style="color: grey">(c24827197bf20b4cb55a6b885f023074f179159c)</span></li>
<li>kcms/input/CMakeLists.txt <span style="color: grey">(a2b72a45a3b694b7fa367abf33d0752b0dc9734b)</span></li>
<li>kcms/keyboard/CMakeLists.txt <span style="color: grey">(3db5dc3f938bbe25259067783bda4fdd882f60f6)</span></li>
<li>kcms/keyboard/keyboard_daemon.h <span style="color: grey">(4d7587f9113edea31dd07f23d658818941731df2)</span></li>
<li>kcms/keyboard/layout_tray_icon.h <span style="color: grey">(8338bf26307627747fb434ae8e0903050142aef4)</span></li>
<li>kcms/keyboard/layouts_menu.h <span style="color: grey">(db2f3ff5844e16340ad3ca6102e6b1c4866ad8db)</span></li>
<li>kcms/keyboard/preview/kbpreviewframe.cpp <span style="color: grey">(9735eb02ac6875bb3905fb0bf8183a9d97e0e3e4)</span></li>
<li>kcms/keyboard/tests/CMakeLists.txt <span style="color: grey">(bd62c7d281766bc5c04b0b1e933861d258241cf7)</span></li>
<li>kcms/keyboard/xkb_helper.h <span style="color: grey">(d3dab1d9b05784ae463db44ab941119e5b214986)</span></li>
<li>kcms/phonon/CMakeLists.txt <span style="color: grey">(8f964e2041cc812bf70f6a48e2915427f088b990)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121762/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>