<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121581/">https://git.reviewboard.kde.org/r/121581/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Dezember 18th, 2014, 1:05 vorm. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think it's a useful component that can end up being really useful elsewhere, therefore I think kdeclarative it's a good place to be.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd say it would be better to have it in a separate qml module. IIRC, the idea of kquickcontrols was to provide components that extend QtQuick Controls, rather than such generic components (see the KeySequenceButton). In fact, I would expect that to use something like that, I'd have to "import org.kde.plotter" or "import QtQuick.Plotter" rather than something else that happens to provide a Plotter class.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also I miss some more development over it, to get started some unit tests would be perfect, or at least an example application we can look at to test small things or just learn how to use it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Last, have you looked at the plotting component developed for ktouch? Is it comparable in any way? I'd love to duplicate there.
https://projects.kde.org/projects/kde/kdeedu/kqtquickcharts/repository</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks!</p></pre>
</blockquote>
<p>On Dezember 18th, 2014, 9:04 vorm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Own import, i'm not sure i like that much having a ton of very small ones, we're already loading too many plugins :/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kquickcharts, I didn't knew that thing existed, if somebody told me before, I would have done things differently, damn.
Anyways, i see it's similar, but not the same. it's still a qquickpainteditem and doesn't seem to support stacked graphs/spline interpolation, so seems slightly different.
Maybe this may stay as small thing (even just in extracomponents) and kquickcharts for applications, boh</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As the author of KQtQuickGraphs I think both components are sufficiently different to co-exist, as they serve different purposes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The plotter componednt (as the name suggests) seems to provides realtime visualization over a trend of a continiously changing value. Drawing performance is really important, as the data may always change, flexibility not that much.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The components in KQtQuickGraphs aim to be a more general approach to data visualization, used in KDE Edu (currently KTouch and Artikulate) to illustrate the learner's progress.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also the plotter is Qt5 ready and uses OpenGL for its drawing needs, so currently it is in a better shape than KQtQuickGraphs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So +1 from me.</p></pre>
<br />
<p>- Sebastian</p>
<br />
<p>On Dezember 17th, 2014, 4:20 nachm. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Dez. 17, 2014, 4:20 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is an alternative, mutually exclusive to
https://gerrit.vesnicky.cesnet.cz/r/#/c/244
and dependent from
https://git.reviewboard.kde.org/r/121575/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">since the plotter component doesn't depend from libplasma, it may be useful to have it outside of libplasma, so any applciation that wants it may use it.
Any opinion whether this should go here or in libplasma is welcome.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(233ccce)</span></li>
<li>src/qmlcontrols/kquickcontrols/CMakeLists.txt <span style="color: grey">(eef0420)</span></li>
<li>src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/plotter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/plotter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/qmldir <span style="color: grey">(31d8b14)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121581/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>