<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121473/">https://git.reviewboard.kde.org/r/121473/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
 <br />







<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/121473/diff/5/?file=332879#file332879line12" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/mouse/CMakeLists.txt</a>
    <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">plasma_engine_mouse</span><span class="hl"> </span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDE4_KDEUI_LIBS</span></span><span class="o"><span class="hl">}</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::Plasma</span></span><span class="hl"> </span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">X11_LIBRARIES</span></span><span class="o"><span class="hl">}</span></span><span class="p"><span class="hl">)</span></span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">plasma_engine_mouse</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This does not build, add Qt5::Widgets and KF5::WindowSystem in target_link_libraries and you are good to go..</p></pre>
 </div>
</div>
<br />



<p>- Bhushan Shah</p>


<br />
<p>On December 13th, 2014, 5:38 p.m. IST, Andrea Scarpino wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Andrea Scarpino.</div>


<p style="color: grey;"><i>Updated Dec. 13, 2014, 5:38 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Rebased https://git.reviewboard.kde.org/r/114260/</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dataengines/mouse/CMakeLists.txt <span style="color: grey">(29cab878bd1fb514d7ac025134fbfb58a5a1376e)</span></li>

 <li>dataengines/mouse/cursornotificationhandler.h <span style="color: grey">(3b571f8f5ffe6db4efeef7827acf003911bcd5dc)</span></li>

 <li>dataengines/mouse/cursornotificationhandler.cpp <span style="color: grey">(cf1c3fbe91a9afee5090d167dd6cd51637df04d4)</span></li>

 <li>dataengines/mouse/mouseengine.h <span style="color: grey">(d55565dc3875b794dce14054d9a8b77cef9b2347)</span></li>

 <li>dataengines/mouse/mouseengine.cpp <span style="color: grey">(f1c898150e04b44dad1c8a0fc757c1ffdf94941b)</span></li>

 <li>dataengines/CMakeLists.txt <span style="color: grey">(cae926b550cdd69aa0194e19bc4818c597e174c0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121473/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>