<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120949/">https://git.reviewboard.kde.org/r/120949/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">looks a bit overkill?</p></pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On novembre 2nd, 2014, 10:09 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2014, 10:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
but need to come from the qml. This is a first attempt posting to get
feedback about the approach etc.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds and runs, currently doesn't shuffle, to test the result image works and appears.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/fifteenPuzzle/package/contents/config/main.xml <span style="color: grey">(0dd804a12ddb0c7c2daaced1b92582f0deff494f)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml <span style="color: grey">(bf9581bd78c1c7690fc16f01e440adad0fc98766)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/Piece.qml <span style="color: grey">(c386570aebdf4323e3132aa05445b38383149dea)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/configAppearance.qml <span style="color: grey">(d78c91b6e4182a2e461c1ee355b6ad30b63fbc68)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/main.qml <span style="color: grey">(c76eaeb4d936fe917d99375722905c2f002c33e6)</span></li>
<li>applets/fifteenPuzzle/plugin/fifteenimageprovider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/CMakeLists.txt <span style="color: grey">(c7e6a718a6211e0cde1121609ed28ec0fe8448f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>