<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109832/">https://git.reviewboard.kde.org/r/109832/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 29th, 2014, 12:57 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line405" style="color: black; font-weight: bold; text-decoration: underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">405</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">text</span> <span class="o">=</span> <span class="s2">"("</span> <span class="o">+</span> <span class="nx">text</span> <span class="o">+</span> <span class="s2">")"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i18n this?</p></pre>
</blockquote>
<p>On October 29th, 2014, 3:20 p.m. CET, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think this is neccessary. The braces are just used to indicate that a window is minimized. They have no lingustic meaning in this context.</p></pre>
</blockquote>
<p>On October 29th, 2014, 4:46 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You cannot assume that a language uses exactly this kind of braces in that order:
i18nc("braces just denote the window is minimized", "(%1)", text)</p></pre>
</blockquote>
<p>On October 29th, 2014, 5:09 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's not about linguistic meaning, it's more about if those ()s will make sense in eg. Japaneese language or Arabic.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Simple rule to remember: "if the string is going to appear anywhere on the screen, the whole string must be in i18n" ;)</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the usage of ()s for minimized windows has been used in KWin without i18n since at least as long as I'm involved in the project. I can look up when it got introduced and I would not be surprised if it's since KDE 2.0. Given that and no translators ever complained, I wouldn't change it ;-)</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On October 29th, 2014, 4:22 p.m. CET, Andre Heinecke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin, Plasma and Martin Gräßlin.</div>
<div>By Andre Heinecke.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2014, 4:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=292566">292566</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm reopening this review request as I have updated this Window Switcher for Plasma 5.1 and would like to get another review to check if there are any suggestions or issues regarding the port to the new API.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Secondly I would like to ask again to have this Window Switcher Layout included in the KWin repository. I would prefer it if users could obtain this layout from their trusted distributors and did not have to rely on an unverifyable third party download to obtain this plugin. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As suggested in the original review I've put this up on kde-look and recieved some positive feedback. But I really feel that it is rotting away there and that KDE-Look is not a good place to distribute executable plugins.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IMHO the approach of this Window Switcher is different enough from the others included in KWin to be a useful addition to the fold. Especially as this behavior is already familiar to KDE users from some versions < 4.6</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It should also be close enough to the other layouts like thumbnails to keep maintenance very similar (I've mostly looked at the changes made to thumbnails to adapt this for Plasma 5)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Original description:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This Layout tries to mimic some of the old KDE 4.6 tabbox behavior and layout, it scales the thumbnails shown in the tabbox to avoid scrolling.
There are also three different states in this layout depending on the size of the scaled thumbnails to provide appropriate information even when there are many opened windows.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">States:
1. Thumbnails are larger then 200px: Show the Title and the Icon of the Window directly below the thumbnail.
2. Thumbnails are between 200px and 64px: Thumbnails are shown together with the icon but only the title of the currently selected window is shown.
3. Thumbnails would be smaller then 64px: Only the Icons of the windows are shown and the title of the currently selected window (like big icons)
If the Thumbnails would be smaller then 32px the tabbox starts to scroll in the Icon Only state.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Size of the thumbnails depends on the screen size and the number of opened windows.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with plasma 5.3.1 from Kubuntu next / unstable repositories.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tabbox/qml/CMakeLists.txt <span style="color: grey">(fc55ab9)</span></li>
<li>tabbox/qml/clients/scaling/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tabbox/qml/clients/scaling/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109832/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>