<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120568/">https://git.reviewboard.kde.org/r/120568/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120568/diff/1/?file=318115#file318115line102" style="color: black; font-weight: bold; text-decoration: underline;">kcms/componentchooser/componentchooserbrowser.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CfgBrowser::save(KConfig *)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">102</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">defaultApp</span><span class="p">.</span><span class="n">writeXdgListEntry</span><span class="p">(</span><span class="s">"x-scheme-handler/http"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">(</span><span class="s">"kfmclient_html.desktop"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, I am very much against this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The whole point of "use the right KDE app" is to use the right KDE app, not to fire up kfmclient_html for everything including text files, images, calligra documents etc.
The "html" suffix is especially wrong since it would try to use khtmlpart or webkitpart for all of this (explicit mimetype on the command-line).
At least using kde-open would work for all mimetypes, but this is slower (one more intermediate process) than letting the calling app use KRun directly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know that gnome saves the webbrowser as x-scheme-handler/http, but I have always considered this a mistake (and we discussed it at length on the xdg list, so the status quo will remain).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One solution would be to keep this code (with kde-open) but then special case "if the http scheme handler is kde-open then use KRun directly" in the kio code that looks up x-scheme-handler stuff (grep says: KRun and DesktopExecParser).</p></pre>
</div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On October 12th, 2014, 8:40 p.m. UTC, Luc Menut wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and David Faure.</div>
<div>By Luc Menut.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2014, 8:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Save the default browser by writing x-scheme-handler/http and x-scheme-handler/https into the group [Default Applications] in the file mimeapps.list .
Nowadays, many applications look at user preferences for x-scheme-handler/http to determine the default browser, so setting this value would increase interoperability with these applications.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">regards,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Luc Menut - Mageia</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: I don't have write access to kde git, so could you commit the change if the patch looks fine. Thanks.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/componentchooser/componentchooserbrowser.cpp <span style="color: grey">(61af1fd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120568/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>