<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120542/">https://git.reviewboard.kde.org/r/120542/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know I've said that before, but I'm a stubborn person.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It would be really cool if you considered these packages kdevplatform projects. This way these plasmoid projects would be a bit less of a special case and we could start to integrate them. Doesn't it make sense?</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On October 9th, 2014, 4:21 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2014, 4:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the new version of our package viewer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The technical differences between the new and the old one are:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> the old one was a QDockWidget which was hardcoded inside plasmate
the new one is a KDevPlatform plugin
</em> the new one requires less code because we reuse KDevelop::ProjectModel</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Visually I tried to avoid any changes. The only visual difference is that
we are missing the "New.." entries.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The screenshots show the new package viewer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Commits</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Cleanup the packagehandler, plasmoidhandler and themehandler
We will use KDevelop<span style="color: #666666">::</span>PackageModel which is a QAIM with its own
info so we don<span style="border: 1px solid #FF0000">'</span>t need our nodes. What we need is a a way
(PackageModel<span style="color: #666666">::</span>description) which will associate <span style="color: #008000; font-weight: bold">for</span> example
the filename <span style="color: #BA2121">"main.qml"</span> to <span style="color: #BA2121">"Mainscript"</span>.
</pre></div>
</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Add the packagemanagerview plugin
This is a plugin which shows the files of the package according to the
package structure. We reuse the KDevelop<span style="color: #666666">::</span>ProjectModel as our model and we
just proxy it by using QIDentityProxyModel.
</pre></div>
</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/tests/themehandlertest.h <span style="color: grey">(a080d14)</span></li>
<li>plasmate/tests/themehandlertest.cpp <span style="color: grey">(42dab7b)</span></li>
<li>plasmate/plugins/packagemanagerview/packagemanagerview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/packagemanagerviewplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/packagemanagerviewplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/proxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/proxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/tests/plasmoidhandlertest.h <span style="color: grey">(e888c53)</span></li>
<li>plasmate/tests/plasmoidhandlertest.cpp <span style="color: grey">(a6abc98)</span></li>
<li>plasmate/CMakeLists.txt <span style="color: grey">(3380f82)</span></li>
<li>plasmate/packagehandler/packagehandler.h <span style="color: grey">(7dbc3bb)</span></li>
<li>plasmate/packagehandler/packagehandler.cpp <span style="color: grey">(ead1f37)</span></li>
<li>plasmate/packagehandler/plasmoidhandler.h <span style="color: grey">(11ca4ae)</span></li>
<li>plasmate/packagehandler/plasmoidhandler.cpp <span style="color: grey">(60009c9)</span></li>
<li>plasmate/packagehandler/themehandler.h <span style="color: grey">(6c95d83)</span></li>
<li>plasmate/packagehandler/themehandler.cpp <span style="color: grey">(4d88361)</span></li>
<li>plasmate/plugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/kdevpackagemanagerview.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/kdevpackagemanagerview.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/packagemanagerview/packagemanagerview.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120542/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/a4995d07-5564-41c5-a1f7-2cf39e5cd13f__packagemanagerview_theme.png">theme package</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/0bc938b4-495e-4df9-bdf9-4780f12619e9__packagemanagerview_plasmoid2.png">plasmoid package</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>