<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120038/">https://git.reviewboard.kde.org/r/120038/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On September 2nd, 2014, 5:56 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2014, 5:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the second part of the review 'Port plasmate to KDevPlatform's shell'.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This review contains various removes from plasmate's source code.
The removed code is either depracated due to the port to KDevPlatform
or it hasn't been used by anyone AFAIK since 2011.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also this review changes the directory structure of plasmate's repository.
This change makes sense with the new plugins that will be added and it reflects
the KDevelop's one.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So the new directory structure is something like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">plasmate
-plasmate
--app (this is the place from which the plasmate binary will be created)
--plugins (It's not there yet because we don't have any yet :)
-plasmoidviewer
-engineexplorer</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is the list of commits for this review </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Commits:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">The big cleanup.
Most of those stuff are deprecated due to the port to KDevPlatform
and the rest of them are leftover from years ago
<span style="color: #666666">----</span>
Change the directory structure of plasmate<span style="color: #666666">/</span>plasmate
<span style="color: #666666">*</span> move all the Startpage related files to plasmate<span style="color: #666666">/</span>plasmate<span style="color: #666666">/</span>app<span style="color: #666666">/</span>startpage
<span style="color: #666666">*</span> move the Startpage related tests to plasmate<span style="color: #666666">/</span>plasmate<span style="color: #666666">/</span>app<span style="color: #666666">/</span>tests
<span style="color: #666666">*</span> move ProjectManager<span style="color: #666666">::</span>exportProject to Publisher<span style="color: #666666">::</span>exportProject.
the ProjectManager wasn<span style="border: 1px solid #FF0000">'</span>t making any use of it and by moving the
method, the Publisher doesn<span style="border: 1px solid #FF0000">'</span>t depend anymore to the ProjectManager
<span style="color: #666666">-----</span>
Cleanup the packagehandler, plasmoidhandler and themehandler
We will use KDevelop<span style="color: #666666">::</span>PackageModel which is a QAIM with its own
info so we don<span style="border: 1px solid #FF0000">'</span>t need our nodes. What we need is a a way
(PackageModel<span style="color: #666666">::</span>description) which will associate <span style="color: #008000; font-weight: bold">for</span> example
the filename <span style="color: #BA2121">"main.qml"</span> to <span style="color: #BA2121">"Mainscript"</span>.
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/tests/modeltest.cpp <span style="color: grey">(d356b26)</span></li>
<li>plasmate/tests/packagemodeltest.h <span style="color: grey">(806d8f1)</span></li>
<li>plasmate/tests/packagemodeltest.cpp <span style="color: grey">(27907d6)</span></li>
<li>plasmate/tests/plasmoidhandlertest.h <span style="color: grey">(e888c53)</span></li>
<li>plasmate/tests/plasmoidhandlertest.cpp <span style="color: grey">(a6abc98)</span></li>
<li>plasmate/tests/projecthandlertest.h <span style="color: grey">(8f6b903)</span></li>
<li>plasmate/tests/projecthandlertest.cpp <span style="color: grey">(afeca9c)</span></li>
<li>plasmate/sidebartablewidget.cpp <span style="color: grey">(c9980e1)</span></li>
<li>plasmate/startpage.h <span style="color: grey">(a81176c)</span></li>
<li>plasmate/startpage.cpp <span style="color: grey">(ab94392)</span></li>
<li>plasmate/startpage.ui <span style="color: grey">()</span></li>
<li>plasmate/test-kpart/CMakeLists.txt <span style="color: grey">(761afcd)</span></li>
<li>plasmate/test-kpart/kparttut1ui.rc <span style="color: grey">(a76749e)</span></li>
<li>plasmate/test-kpart/main.cpp <span style="color: grey">(9d67674)</span></li>
<li>plasmate/test-kpart/mainwindow.h <span style="color: grey">(ea517b3)</span></li>
<li>plasmate/test-kpart/mainwindow.cpp <span style="color: grey">(a18a66a)</span></li>
<li>plasmate/tests/CMakeLists.txt <span style="color: grey">(1b5632a)</span></li>
<li>plasmate/tests/modeltest.h <span style="color: grey">(45c68f4)</span></li>
<li>plasmate/sidebardelegate.cpp <span style="color: grey">(07992ac)</span></li>
<li>plasmate/sidebaritem.cpp <span style="color: grey">(40ffc99)</span></li>
<li>plasmate/sidebartablewidget.h <span style="color: grey">(73856e7)</span></li>
<li>plasmate/projectmanager/projectmanager.cpp <span style="color: grey">(d691b44)</span></li>
<li>plasmate/publisher/publisher.h <span style="color: grey">(1faa149)</span></li>
<li>plasmate/publisher/publisher.cpp <span style="color: grey">(52173a9)</span></li>
<li>plasmate/sidebar.h <span style="color: grey">(08f26eb)</span></li>
<li>plasmate/sidebar.cpp <span style="color: grey">(7b7aff1)</span></li>
<li>plasmate/sidebardelegate.h <span style="color: grey">(09fc506)</span></li>
<li>plasmate/projecthandler.cpp <span style="color: grey">()</span></li>
<li>plasmate/projectmanager/projectmanager.h <span style="color: grey">(7a0f875)</span></li>
<li>plasmate/plasmate.desktop <span style="color: grey">()</span></li>
<li>plasmate/plasmate.knsrc <span style="color: grey">()</span></li>
<li>plasmate/projecthandler.h <span style="color: grey">()</span></li>
<li>plasmate/packagemodel.h <span style="color: grey">(2ac1cb2)</span></li>
<li>plasmate/packagemodel.cpp <span style="color: grey">(93f158a)</span></li>
<li>plasmate/packagehandler/packagehandler.h <span style="color: grey">(7dbc3bb)</span></li>
<li>plasmate/packagehandler/packagehandler.cpp <span style="color: grey">(ead1f37)</span></li>
<li>plasmate/packagehandler/plasmoidhandler.h <span style="color: grey">(11ca4ae)</span></li>
<li>plasmate/packagehandler/plasmoidhandler.cpp <span style="color: grey">(60009c9)</span></li>
<li>plasmate/packagehandler/themehandler.h <span style="color: grey">(6c95d83)</span></li>
<li>plasmate/packagehandler/themehandler.cpp <span style="color: grey">(4d88361)</span></li>
<li>plasmate/editors/svg/tests/battery-oxygen-inkscape.svgz <span style="color: grey">(ce87277)</span></li>
<li>plasmate/editors/svg/tests/battery-oxygen.svgz <span style="color: grey">(ce87277)</span></li>
<li>plasmate/editors/svg/tests/test_svg.cpp <span style="color: grey">(bc725ab)</span></li>
<li>plasmate/editors/text/texteditor.h <span style="color: grey">(4ab8eed)</span></li>
<li>plasmate/editors/text/texteditor.cpp <span style="color: grey">(2e346ca)</span></li>
<li>plasmate/mainwindow.h <span style="color: grey">(a609750)</span></li>
<li>plasmate/mainwindow.cpp <span style="color: grey">(c7c95a9)</span></li>
<li>plasmate/modeltest/dynamictreemodel.h <span style="color: grey">(6fbd02a)</span></li>
<li>plasmate/modeltest/dynamictreemodel.cpp <span style="color: grey">(2428ebe)</span></li>
<li>plasmate/modeltest/modeltest.h <span style="color: grey">(a5a6777)</span></li>
<li>plasmate/modeltest/modeltest.cpp <span style="color: grey">(a5f1fe1)</span></li>
<li>plasmate/editors/svg/tests/background.svg <span style="color: grey">(ca130f2)</span></li>
<li>plasmate/editors/svg/tests/background.svgz <span style="color: grey">(f9e4b1d)</span></li>
<li>plasmate/editors/editpage.h <span style="color: grey">(98a09ca)</span></li>
<li>plasmate/editors/editpage.cpp <span style="color: grey">(f21ec25)</span></li>
<li>plasmate/editors/metadata/metadataeditor.cpp <span style="color: grey">(c07fafd)</span></li>
<li>plasmate/editors/svg/CMakeLists.txt <span style="color: grey">(0214310)</span></li>
<li>plasmate/editors/svg/svgviewer.h <span style="color: grey">(01d4856)</span></li>
<li>plasmate/editors/svg/svgviewer.cpp <span style="color: grey">(469b3ff)</span></li>
<li>plasmate/dockwidgetshandler.h <span style="color: grey">(5a68554)</span></li>
<li>plasmate/dockwidgetshandler.cpp <span style="color: grey">(274bec8)</span></li>
<li>plasmate/editors/CMakeLists.txt <span style="color: grey">(e8a11d0)</span></li>
<li>plasmate/CMakeLists.txt <span style="color: grey">(5415db7)</span></li>
<li>plasmate/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/app/main.cpp <span style="color: grey">(3790ac2)</span></li>
<li>plasmate/app/plasmateapp.cpp <span style="color: grey">(46dda60)</span></li>
<li>plasmate/app/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/tests/themehandlertest.h <span style="color: grey">(a080d14)</span></li>
<li>plasmate/tests/themehandlertest.cpp <span style="color: grey">(42dab7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>