<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120441/">https://git.reviewboard.kde.org/r/120441/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2014, 12:23 a.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Minor issues and +1 to Martin G's note about commented out debugs...imo they should just go</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok, will remove it in final revision</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2014, 12:23 a.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120441/diff/3/?file=316813#file316813line115" style="color: black; font-weight: bold; text-decoration: underline;">signalplotter/ksignalplotter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KSignalPlotter::addBeam( const QColor &color )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">(</span><span class="mi"><span class="hl">1215</span></span><span class="p">)</span> <span class="o"><<</span> <span class="s">"Invalid color"</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">113</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Invalid color"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should probably be qCDebug to keep the category</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sure, can take care of that. i'd like to do that in separate commit, as it's not strictly porting away from KDELibs4Support</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2014, 12:23 a.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120441/diff/3/?file=316814#file316814line7" style="color: black; font-weight: bold; text-decoration: underline;">tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">LINK_LIBRARIES</span> <span class="s">KF5::<span class="hl">KDE4Support</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::</span>ProcessUi</span> <span class="s">Qt5::Test</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">LINK_LIBRARIES</span> <span class="s">KF5::ProcessUi</span> <span class="s">Qt5::Test</span><span class="hl"> </span><span class="s"><span class="hl">KF5::I18n</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is the I18n still needed here in the tests linkage? I see only the signalplottertest.cpp using i18n (and even that usage could possibly be removed but meh, it's just tests)</p></pre>
</blockquote>
<p>On October 7th, 2014, 12:29 a.m. CEST, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests shouldn't contain i18n()</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the linkage is also due to signalplotter/ksignalplotter.h include in various tests</p></pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On October 6th, 2014, 6:29 p.m. CEST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2014, 6:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">some libs needed just headers removal, other something more ...
found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds, tests pass, ksysguard functions as it did</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(61bd704)</span></li>
<li>ksgrd/CMakeLists.txt <span style="color: grey">(64ad24a)</span></li>
<li>ksgrd/SensorManager.cpp <span style="color: grey">(9e1534a)</span></li>
<li>lsofui/CMakeLists.txt <span style="color: grey">(2b0c8ac)</span></li>
<li>lsofui/lsof.h <span style="color: grey">(e87ac26)</span></li>
<li>processcore/CMakeLists.txt <span style="color: grey">(0ca833e)</span></li>
<li>processcore/processes.cpp <span style="color: grey">(3e63218)</span></li>
<li>processcore/processes_atop_p.cpp <span style="color: grey">(369df36)</span></li>
<li>processcore/processes_remote_p.cpp <span style="color: grey">(361bf24)</span></li>
<li>processui/CMakeLists.txt <span style="color: grey">(150e198)</span></li>
<li>processui/KTextEditVT.cpp <span style="color: grey">(064737b)</span></li>
<li>processui/ProcessFilter.cpp <span style="color: grey">(b37766e)</span></li>
<li>processui/ProcessModel.cpp <span style="color: grey">(8b87d41)</span></li>
<li>processui/ProcessModel_p.h <span style="color: grey">(6bc9d09)</span></li>
<li>processui/ReniceDlg.h <span style="color: grey">(fa445a5)</span></li>
<li>processui/ReniceDlg.cpp <span style="color: grey">(218412c)</span></li>
<li>processui/ksysguardprocesslist.cpp <span style="color: grey">(d3403cc)</span></li>
<li>processui/scripting.cpp <span style="color: grey">(fd0a610)</span></li>
<li>signalplotter/CMakeLists.txt <span style="color: grey">(67aa8bb)</span></li>
<li>signalplotter/kgraphicssignalplotter.h <span style="color: grey">(9f698d4)</span></li>
<li>signalplotter/ksignalplotter.cpp <span style="color: grey">(91d9eee)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(a74c6a2)</span></li>
<li>tests/graphicssignalplotterbenchmark.cpp <span style="color: grey">(e27eb1a)</span></li>
<li>tests/processtest.cpp <span style="color: grey">(6aa9809)</span></li>
<li>tests/signalplotterbenchmark.cpp <span style="color: grey">(8b827d6)</span></li>
<li>tests/signalplottertest.cpp <span style="color: grey">(bb2108e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120441/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>