<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120325/">https://git.reviewboard.kde.org/r/120325/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2014, 8:47 vorm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120325/diff/1/?file=314629#file314629line39" style="color: black; font-weight: bold; text-decoration: underline;">applets/binary-clock/package/contents/ui/BinaryClock.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">Layout.minimumWidth:</span> <span class="p">(</span><span class="nx">Layout</span><span class="p">.</span><span class="nx">height</span><span class="o">-</span><span class="mi">5</span><span class="o">*</span><span class="nx">units</span><span class="p">.</span><span class="nx">smallSpacing</span><span class="p">)</span><span class="o">*</span><span class="nx">dots</span><span class="o">/</span><span class="mi">4</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">perhaps the reason it looks too small in panels is that should use main.height instead of Layout.height?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Panel layout still needs some work</p></pre>
<br />
<p>- Joseph</p>
<br />
<p>On Oktober 1st, 2014, 8:21 nachm. UTC, Joseph Wenninger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Joseph Wenninger.</div>
<p style="color: grey;"><i>Updated Okt. 1, 2014, 8:21 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd like somebody to have a look at it to tell me, if I'm on the right way or if I'm completely wrong</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works on the desktop, but the dots are too small in the panel</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(63e6e25628d18ee474231acd2a21711841dee592)</span></li>
<li>applets/binary-clock/CMakeLists.txt <span style="color: grey">(b42a6e76752af3cc800ad5455ba0678a18a0ce45)</span></li>
<li>applets/binary-clock/Messages.sh <span style="color: grey">(40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4)</span></li>
<li>applets/binary-clock/binaryclock.h <span style="color: grey">(5ae83dfff9c473bd484b99d49330093b6e091975)</span></li>
<li>applets/binary-clock/binaryclock.cpp <span style="color: grey">(75c4548588ff15e2316dd1c2e888ad8c07f7f78b)</span></li>
<li>applets/binary-clock/clockConfig.ui <span style="color: grey">(0c2cec7925dd9e1ff92d7cd9d99005dca20497b0)</span></li>
<li>applets/binary-clock/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/BinaryClock.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/Dot.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/DotColumn.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/configGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/plasma-applet-binaryclock.desktop <span style="color: grey">(9f9229bd3ef2a2a31fc545cfbc60702f0bb411b5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120325/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>