<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120314/">https://git.reviewboard.kde.org/r/120314/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2014, 10:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes an issue which allowed deselecting all timezones, now it popups a messagebox informing the user and then proceeds to select the Local zone.
Two things, in this diff I forgot the i18n for the dialog text (fixed locally) and for some reason the checkbox next to Local does not get checked properly in the above case, even though the model /has/ correct data, not sure what's going on in there (I'll be gone for most of today so if anyone has any idea, please let me know).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've picked up Kai's branch where he started the timezone support and finished it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New features:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* timezones tab in the config<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* changing timezones by scrolling a wheel on the clock<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* that's optional, defaults to off<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* displaying non-local timezones as either city or abbreviation<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* "Show time zone" config option is now changed to "Show local time zone" as foreign zones are always displayed by default</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What's still missing:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* selecting default timezone in the config (should be fairly easy; currently the last used is restored on login<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/timezonemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/plugin/timezonemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/time/timesource.cpp <span style="color: grey">(b79fd7c)</span></li>
<li>applets/digital-clock/plugin/timezonedata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/plugin/digitalclockplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/plugin/processrunnerplugin.h <span style="color: grey">(2b6317b)</span></li>
<li>applets/digital-clock/plugin/processrunnerplugin.cpp <span style="color: grey">(ed039a3)</span></li>
<li>applets/digital-clock/plugin/qmldir <span style="color: grey">(3d57bbb)</span></li>
<li>applets/digital-clock/package/contents/ui/configAppearance.qml <span style="color: grey">(01f6878)</span></li>
<li>applets/digital-clock/package/contents/ui/configTimeZones.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/package/contents/ui/main.qml <span style="color: grey">(e78f1f3)</span></li>
<li>applets/digital-clock/plugin/CMakeLists.txt <span style="color: grey">(0590e6e)</span></li>
<li>applets/digital-clock/plugin/digitalclockplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/package/contents/config/config.qml <span style="color: grey">(f897c9a)</span></li>
<li>applets/digital-clock/package/contents/config/main.xml <span style="color: grey">(cbeb02f)</span></li>
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: grey">(614e172)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120314/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png">Timezone & date displayed</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png">Timezone without date</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>