<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120316/">https://git.reviewboard.kde.org/r/120316/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2014, 6 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use a different corona for the standalone mode, doesn't overcomplicate it.
scriptengine becomes slightly uglier tough</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is as alternative to https://git.reviewboard.kde.org/r/120270/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/shellmanager.cpp <span style="color: grey">(f6472cb)</span></li>
<li>shell/standaloneappcorona.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/standaloneappcorona.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/scripting/scriptengine.cpp <span style="color: grey">(5b035ea)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(eeb01af)</span></li>
<li>shell/shellmanager.h <span style="color: grey">(eef25aa)</span></li>
<li>shell/main.cpp <span style="color: grey">(e737007)</span></li>
<li>shell/scripting/scriptengine.h <span style="color: grey">(6ce8b51)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(e835bf8)</span></li>
<li>shell/desktopview.h <span style="color: grey">(6aeeeb6)</span></li>
<li>shell/desktopview.cpp <span style="color: grey">(08c1c32)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120316/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>