<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120318/">https://git.reviewboard.kde.org/r/120318/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 22nd, 2014, 3:38 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I like the idea!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Suggestion for the "which package manager to use" part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then.</p></pre>
</blockquote>
<p>On September 22nd, 2014, 3:49 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why would distros need a GUI for configuring it?</p></pre>
</blockquote>
<p>On September 22nd, 2014, 3:55 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">distros don't need the GUI, but the kconfig key. Some distros provide multiple tools, though and then the user might want to be able to configure it.</p></pre>
</blockquote>
<p>On September 22nd, 2014, 3:57 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was planning to add a config key to Kicker for now, but I agree a more canonical workspace-level key and an API in KToolInvocation would be cool. Next Frameworks release maybe?</p></pre>
</blockquote>
<p>On September 22nd, 2014, 4:18 p.m. UTC, <b>Matthias Klumpp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In theory, a call on the PackageKit interface should trigger whatever implements the PackageKit session DBus interface (on KDE that's only Apper at time) to display any GUI dialogs.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
But probably showing the application prior to removing it in a software center is a good idea anyway :)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Would it make sense to send the application-name to the software center, and have it figure out the package name, instead of doing that prior to calling the SC? Might be a bit nicer...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As a sidenote: Using LibAppstreamQt could be a future option for resolving application-names to packages - depending on the distribution's package-manager, calls to SearchFiles() could be a bit slow. Drawback of using that lib is that distros need to ship with AppStream metadata, which currently only OpenSUSE and Fedora do - Debian will support is soon, and Ubuntu maybe as well (both distros currently have partial support via AppInstall data).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That feature looks great, I hope it doesn't conflict with http://dantti.wordpress.com/2010/11/25/yup-laziness-is-a-virtue/ , although honestly I need to check if that Apper feature actually still works...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Klumpp: Well, we still want to do the lookup on the kicker side, because we don't want to show the option in case its not removable. Otherwise we would be rising the user's hopes for little reason.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 22nd, 2014, 3:34 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Eike Hein.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2014, 3:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It adds an entry on the menu that is called "Remove '<packagename>'" that opens a software center. I set it to muon-discover for now, but this should be iterated over.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I uninstalled openarena, selfcompiled software cannot removed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7b794ff)</span></li>
<li>applets/kicker/CMakeLists.txt <span style="color: grey">(0688732)</span></li>
<li>applets/kicker/plugin/appsmodel.cpp <span style="color: grey">(b88d711)</span></li>
<li>applets/kicker/plugin/findpackagenamejob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kicker/plugin/findpackagenamejob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>config-workspace.h.cmake <span style="color: grey">(58a11d4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120318/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>