<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120276/">https://git.reviewboard.kde.org/r/120276/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler.</div>
<div>By Andrei Amuraritei.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2014, 10:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix issues specified.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">comic DataEngine initial port to frameworks.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Thanks notmart, d_ed, sebas, bshas etc for helping.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/CMakeLists.txt <span style="color: grey">(04c7985)</span></li>
<li>dataengines/comic/CMakeLists.txt <span style="color: grey">(8e382e6)</span></li>
<li>dataengines/comic/cachedprovider.h <span style="color: grey">(baac8a9)</span></li>
<li>dataengines/comic/cachedprovider.cpp <span style="color: grey">(caca25e)</span></li>
<li>dataengines/comic/comic.h <span style="color: grey">(8cc3969)</span></li>
<li>dataengines/comic/comic.cpp <span style="color: grey">(7130f44)</span></li>
<li>dataengines/comic/comic_package.h <span style="color: grey">(32be381)</span></li>
<li>dataengines/comic/comic_package.cpp <span style="color: grey">(6d2ff0b)</span></li>
<li>dataengines/comic/comic_package_plugin.cpp <span style="color: grey">(d997947)</span></li>
<li>dataengines/comic/comicprovider.h <span style="color: grey">(630ee8d)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: grey">(ab248a5)</span></li>
<li>dataengines/comic/comicproviderkross.h <span style="color: grey">(46a9072)</span></li>
<li>dataengines/comic/comicproviderkross.cpp <span style="color: grey">(9820f05)</span></li>
<li>dataengines/comic/comicproviderwrapper.h <span style="color: grey">(81eee68)</span></li>
<li>dataengines/comic/comicproviderwrapper.cpp <span style="color: grey">(48ced42)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120276/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/7b2d617f-1348-4b5c-ac9c-a4340436a47d__0002-Review-port-of-comic-dataengine.patch">Rev2 of port</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>