<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120276/">https://git.reviewboard.kde.org/r/120276/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Septembrie 19th, 2014, 10:33 p.m. EEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/2/?file=313492#file313492line49" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comic_package.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">//K_EXPORT_PLASMA_PACKAGE_WITH_JSON(ComicPackage, "plasma-dataengine-comic.json")</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You're building this class as MODULE (ie. a plugin) but you don't define any plugin macro (K_PLUGIN_FACTORY), this can't work as a plugin without it</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like you should keep this line (but port to K_PLUGIN_FACTORY)</p></pre>
</blockquote>
<p>On Septembrie 19th, 2014, 11:36 p.m. EEST, <b>Andrei Amuraritei</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please detail this.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I've added </p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">include <KPluginFactory></h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">K_PLUGIN_FACTORY(ComicProviderKrossFactory, registerPlugin<ComicProviderKross>();)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">to comicproviderkross.cpp</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Old code had the usage of the old macro COMICPROVIDER_EXPORT_PLUGIN there.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also should there be a K_EXPORT_PLASMA_PACKAGE_WITH_JSON(ComicPackage, "plasma-packagestructure-comic.json") line at the end of comic_package.cpp ?</p></pre>
<br />
<p>- Andrei</p>
<br />
<p>On Septembrie 19th, 2014, 10:17 p.m. EEST, Andrei Amuraritei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler.</div>
<div>By Andrei Amuraritei.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2014, 10:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">comic DataEngine initial port to frameworks.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Thanks notmart, d_ed, sebas, bshas etc for helping.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/comic/plasma-packagestructure-comic.desktop <span style="color: grey">(67f96c0)</span></li>
<li>dataengines/comic/comic_package.cpp <span style="color: grey">(6d2ff0b)</span></li>
<li>dataengines/comic/comicprovider.h <span style="color: grey">(630ee8d)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: grey">(ab248a5)</span></li>
<li>dataengines/comic/comicproviderkross.h <span style="color: grey">(46a9072)</span></li>
<li>dataengines/comic/comicproviderkross.cpp <span style="color: grey">(9820f05)</span></li>
<li>dataengines/comic/comicproviderwrapper.h <span style="color: grey">(81eee68)</span></li>
<li>dataengines/comic/comicproviderwrapper.cpp <span style="color: grey">(48ced42)</span></li>
<li>dataengines/comic/plasma-dataengine-comic.desktop <span style="color: grey">(f9e5433)</span></li>
<li>dataengines/comic/CMakeLists.txt <span style="color: grey">(8e382e6)</span></li>
<li>dataengines/comic/cachedprovider.cpp <span style="color: grey">(caca25e)</span></li>
<li>dataengines/comic/comic.h <span style="color: grey">(8cc3969)</span></li>
<li>dataengines/comic/comic.cpp <span style="color: grey">(7130f44)</span></li>
<li>dataengines/comic/comic_package.h <span style="color: grey">(32be381)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120276/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>