<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120051/">https://git.reviewboard.kde.org/r/120051/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 3rd, 2014, 10:22 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good stuff. There's a discussion we need to have about where to put it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Explanation for Marco et al: <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- we need this to make a keybaord layout plasmoid like we had in 4.x<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- lockscreen uses the same data, but wants to display it differently</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">org.kde.plasma.workspace is fine or even org.kde.plasma.workspaceintegration<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
and should reside in kde-workspace, since it depends on it in order to be working.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
similar wrkspace specific stuff would go there as well.</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On September 3rd, 2014, 6:39 p.m. UTC, Martin Yrjölä wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Yrjölä.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2014, 6:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes the screenlocker's keyboard layout switcher plugin globally<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
accessible. This is needed for a keyboard layout switcher plasmoid<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
in kdeplasma-addons.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested that org.kde.plasma.workspace.keyboardlayout can be imported in plasmoids in kdeplasma-addons.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Confirmed that the layout switcher still works in the screen locker.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test number 6 fails for me both with and without this commit. Is this a known issue? How should I proceed with this?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6/10 Test #6: ksmserver-lockWindowTest ......................***Failed 3.52 sec</code></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/keyboardlayout.h <span style="color: grey">()</span></li>
<li>ksmserver/screenlocker/greeter/keyboardlayout.cpp <span style="color: grey">()</span></li>
<li>lookandfeel/contents/components/KeyboardLayout.qml <span style="color: grey">(f0198ae519ed7c7e3f3e8fa9ef637302680f4182)</span></li>
<li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: grey">(82acdd6c569622cfca983156ef4b09cd9176417f)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: grey">(611a151826e8b9d5002233960192e131ba1ca93c)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(86794371c6211f3ff2f58717bc91a096a17ad7d3)</span></li>
<li>components/CMakeLists.txt <span style="color: grey">(ac468c0ffdf75f614f5995cbd42bb8d3568e81fc)</span></li>
<li>components/keyboardlayout/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/keyboardlayout/keyboardlayoutplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/keyboardlayout/keyboardlayoutplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/keyboardlayout/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120051/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>