<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119411/">https://git.reviewboard.kde.org/r/119411/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2014, 4:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have separated this task to two reviews, because there are also some<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">git mv</code> in order to have a decent directory structure which I don't have<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
included in this review for readability.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Below is the list of commits from which this review has been made.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">use some private members and improve readability</li>
</ul>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Every project must have a .plasmate file in order to pick the Manager.</li>
</ul>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Initial commit for porting plasmate to kdevplatform</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We introduce a new class named PlasmateApp which will<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
show the Startpage and hide it, when it must do it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You can also test this review from</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
branch: r/119411</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3fc11fb)</span></li>
<li>plasmate/CMakeLists.txt <span style="color: grey">(1a6ce87)</span></li>
<li>plasmate/app/katepartui.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/app/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/app/plasmateapp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/app/plasmateapp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/app/plasmateextention.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/app/plasmateextention.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/app/plasmateui.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/main.cpp <span style="color: grey">(633c4cc)</span></li>
<li>plasmate/plasmateui.rc <span style="color: grey">(41f6025)</span></li>
<li>plasmate/startpage.h <span style="color: grey">(4c77e29)</span></li>
<li>plasmate/startpage.cpp <span style="color: grey">(a65a2cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119411/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png">How plasmate should look like in the end</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>