<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119989/">https://git.reviewboard.kde.org/r/119989/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2014, 12:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">spiffed up the share engine's package structure cmake file.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patchset introduces the use of PackageStructure plugins to plasma-workspace, allowing the removal of ShellPluginLoader everywhere. It also fixes some strange use of PackageStructure in the share DataEngine and updates that PackageStructure to use the JSON-based loading.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this changeset Plasma/Shell, Plasma/LookAndFeel and Plasma/Wallpaper are all plugins and accessible from everywhere that needs them via Plasma::PluginLoader.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ran a full Plasma Desktop session with these changes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/packageplugins/wallpaper/wallpaper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/plasmaquick/shellpluginloader.h <span style="color: grey">(ea0755e4abe841e33777d89cb12a5e689161e51b)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(312003f6f1a27b1c624da17c310a148dff7131a3)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(d67be9782de1faa9890bf85b8b2b517e15f12812)</span></li>
<li>shell/main.cpp <span style="color: grey">(04e1fd168df15bced40bfd84b965fb6f4905ded6)</span></li>
<li>shell/osd.cpp <span style="color: grey">(961c9ca3974337553bcefc1fc2c06222da9114e1)</span></li>
<li>shell/packageplugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/packages.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/packages.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/shellpackage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/shellpackage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/wallpaper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/share/shareprovider.h <span style="color: grey">(c9159cdde6a858fbdca57ad7c5aa258028fd9ac3)</span></li>
<li>dataengines/share/shareprovider.cpp <span style="color: grey">(fd1812fa1263cdf9df7d4340c681a63f8455ce07)</span></li>
<li>dataengines/share/shareservice.h <span style="color: grey">(5fb533d06fc74a52c33e0c8e1052ec93ffc4e11f)</span></li>
<li>dataengines/share/shareservice.cpp <span style="color: grey">(8442b6634e5e55f8717b9684dd41839df8d3d677)</span></li>
<li>krunner/main.cpp <span style="color: grey">(408c5631a8007ac2617c7963cd83146dc4bbceeb)</span></li>
<li>krunner/shellpluginloader.h <span style="color: grey">(9c0f62412eac4d1ad03c681325852d9efe25ccda)</span></li>
<li>krunner/view.cpp <span style="color: grey">(0d986e845e3b9821ef39a874d431a087e2390e8a)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(92e839091412585dddc369d5a4a3beace39e92ae)</span></li>
<li>ksmserver/shellpluginloader.h <span style="color: grey">(6f13d493a800a7479711ef3549cfd9362a593778)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(b4e59a387e5bf857db6314cf1b879e6a775e9f99)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.cpp <span style="color: grey">(474e06d7b189fc368d1f9ba45426ea30392e2a71)</span></li>
<li>lookandfeelaccess/shellpluginloader.h <span style="color: grey">(9c0f62412eac4d1ad03c681325852d9efe25ccda)</span></li>
<li>plasma-windowed/main.cpp <span style="color: grey">(4e9263aad9736b93dc00e7fef74db54b39456cb6)</span></li>
<li>plasma-windowed/plasmaquick/shellpluginloader.h <span style="color: grey">(ea0755e4abe841e33777d89cb12a5e689161e51b)</span></li>
<li>dataengines/share/packagestructure/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/share/plugin_share_package.cpp <span style="color: grey">(c4e2f23f7a65ddc67a94c60dffa3f71701a46b8b)</span></li>
<li>dataengines/share/share_package.h <span style="color: grey">()</span></li>
<li>dataengines/share/share_package.cpp <span style="color: grey">(13f41def3abd5ccf57b8745e3fd6956d10377a7a)</span></li>
<li>dataengines/share/CMakeLists.txt <span style="color: grey">(3d67b137f9a3e37453b8890d0d3c73e6469bae38)</span></li>
<li>dataengines/share/data/CMakeLists.txt <span style="color: grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
<li>dataengines/share/data/plasma-packagestructure-share.desktop <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119989/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>