<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119989/">https://git.reviewboard.kde.org/r/119989/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119989/diff/1/?file=308200#file308200line1" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/share/packagestructure/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_library</span><span class="p">(</span><span class="s">plasma_packagestructure_share</span> <span class="s">MODULE</span> <span class="o">${</span><span class="nv">sharepackage_SRCS</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">having the add_library in a different place to where we define {sharepackage_SRCS} is a bit weird, can we move that alongside.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119989/diff/1/?file=308208#file308208line45" style="color: black; font-weight: bold; text-decoration: underline;">krunner/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if QT_VERSION >= QT_VERSION_CHECK(5, 4, 0)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you don't want to re-add this.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
(probably this is just an un-rebased diff?)</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks ok to me, but I don't understand a lot of this package stuff.</p></pre>
<p>- David Edmundson</p>
<br />
<p>On August 29th, 2014, 11:53 a.m. UTC, Aaron J. Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2014, 11:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patchset introduces the use of PackageStructure plugins to plasma-workspace, allowing the removal of ShellPluginLoader everywhere. It also fixes some strange use of PackageStructure in the share DataEngine and updates that PackageStructure to use the JSON-based loading.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this changeset Plasma/Shell, Plasma/LookAndFeel and Plasma/Wallpaper are all plugins and accessible from everywhere that needs them via Plasma::PluginLoader.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ran a full Plasma Desktop session with these changes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/share/share_package.cpp <span style="color: grey">(13f41def3abd5ccf57b8745e3fd6956d10377a7a)</span></li>
<li>dataengines/share/shareprovider.h <span style="color: grey">(c9159cdde6a858fbdca57ad7c5aa258028fd9ac3)</span></li>
<li>dataengines/share/shareprovider.cpp <span style="color: grey">(fd1812fa1263cdf9df7d4340c681a63f8455ce07)</span></li>
<li>shell/packageplugins/shell/shellpackage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/shellpackage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(92e839091412585dddc369d5a4a3beace39e92ae)</span></li>
<li>ksmserver/shellpluginloader.h <span style="color: grey">(6f13d493a800a7479711ef3549cfd9362a593778)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(b4e59a387e5bf857db6314cf1b879e6a775e9f99)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.cpp <span style="color: grey">(474e06d7b189fc368d1f9ba45426ea30392e2a71)</span></li>
<li>lookandfeelaccess/shellpluginloader.h <span style="color: grey">(9c0f62412eac4d1ad03c681325852d9efe25ccda)</span></li>
<li>plasma-windowed/main.cpp <span style="color: grey">(4e9263aad9736b93dc00e7fef74db54b39456cb6)</span></li>
<li>plasma-windowed/plasma-windowed.desktop <span style="color: grey">(a462867d8a680d714490a0783f85902e373f26a1)</span></li>
<li>plasma-windowed/plasmaquick/shellpluginloader.h <span style="color: grey">(ea0755e4abe841e33777d89cb12a5e689161e51b)</span></li>
<li>plasma-windowed/plasmawindowedcorona.cpp <span style="color: grey">(23bc60384ffbffec90b9cae5ddb6d35b1aaa1fc0)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(d67be9782de1faa9890bf85b8b2b517e15f12812)</span></li>
<li>shell/main.cpp <span style="color: grey">(bb63bdc85ff2a003fa4a5c4e2320383db98da087)</span></li>
<li>shell/osd.cpp <span style="color: grey">(961c9ca3974337553bcefc1fc2c06222da9114e1)</span></li>
<li>shell/packageplugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/packages.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/packages.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/share/share_package.h <span style="color: grey">()</span></li>
<li>dataengines/share/CMakeLists.txt <span style="color: grey">(3d67b137f9a3e37453b8890d0d3c73e6469bae38)</span></li>
<li>dataengines/share/data/CMakeLists.txt <span style="color: grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
<li>dataengines/share/data/plasma-packagestructure-share.desktop <span style="color: grey">()</span></li>
<li>dataengines/share/packagestructure/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/share/plugin_share_package.cpp <span style="color: grey">(c4e2f23f7a65ddc67a94c60dffa3f71701a46b8b)</span></li>
<li>shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/wallpaper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/wallpaper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/plasmaquick/shellpluginloader.h <span style="color: grey">(ea0755e4abe841e33777d89cb12a5e689161e51b)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(d559fcdc99c0066d552e013d3fea249147f50b5f)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(84442ae60cf0f576a077e770ceae82a17721a456)</span></li>
<li>dataengines/share/shareservice.h <span style="color: grey">(5fb533d06fc74a52c33e0c8e1052ec93ffc4e11f)</span></li>
<li>dataengines/share/shareservice.cpp <span style="color: grey">(8442b6634e5e55f8717b9684dd41839df8d3d677)</span></li>
<li>krunner/main.cpp <span style="color: grey">(4d8cc31ff4d78c2daa0f9a6af247b3bd1c317ffa)</span></li>
<li>krunner/shellpluginloader.h <span style="color: grey">(9c0f62412eac4d1ad03c681325852d9efe25ccda)</span></li>
<li>krunner/view.cpp <span style="color: grey">(0d986e845e3b9821ef39a874d431a087e2390e8a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119989/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>