<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119927/">https://git.reviewboard.kde.org/r/119927/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/119927/file/1515/" style="color: black; font-weight: bold; font-size: 9pt;">2014-08-24-212539_505x860_scrot.png</a>
<p>Screenshot</p>
<div><img class="modified-image" src="" width="37" height="23" alt="Yeah, better to have it consistent. I liked Anditosan's mockup for the new system settings. The color chooser looked like this http://wstaw.org/m/2014/08/25/shareimage-S11786.png
So maybe something like the default combobox would be best? Here's the whole mockup https://dribbble.com/shots/1378722-MB-Class-Edit/attachments/198336" /></div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, better to have it consistent. I liked Anditosan's mockup for the new system settings. The color chooser looked like this http://wstaw.org/m/2014/08/25/shareimage-S11786.png</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So maybe something like the default combobox would be best? Here's the whole mockup https://dribbble.com/shots/1378722-MB-Class-Edit/attachments/198336</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/119927/file/1515/" style="color: black; font-weight: bold; font-size: 9pt;">2014-08-24-212539_505x860_scrot.png</a>
<p>Screenshot</p>
<div><img class="modified-image" src="" width="164" height="35" alt="I actually changed this string after the screenshot to "Use circular monitors", but you're right. Radio buttons or a combo box would be better. I'm not really sure if I should make the horizontal bars an option or just make them horizontal automatically if the plasmoid detects it's in a vertical panel. Any thoughts about that?" /></div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I actually changed this string after the screenshot to "Use circular monitors", but you're right. Radio buttons or a combo box would be better. I'm not really sure if I should make the horizontal bars an option or just make them horizontal automatically if the plasmoid detects it's in a vertical panel. Any thoughts about that?</p></pre>
</div>
<br />
<p>- Martin Yrjölä</p>
<br />
<p>On August 24th, 2014, 7:26 p.m. UTC, Martin Yrjölä wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Yrjölä.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2014, 7:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port systemloadviewer plasmoid</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It had a VDG makeover and now there's also circular monitors available in the options.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are regressions as well. These features aren't yet implemented:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Horizontal bar support<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Individual monitors for each cpu</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Probably there are some optimizations to be done. I'm not really sure how I should handle the two types of monitors (bar, circular) correctly. Now I just hide the one that is not enabled in the options.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar monitor is not pixel perfect because of the edge roundings. I haven't been able to test if this plasmoid works with high DPI monitors.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099)</span></li>
<li>applets/systemloadviewer/CMakeLists.txt <span style="color: grey">(6de867aa63e5102a5085667f8106ec09da2c4968)</span></li>
<li>applets/systemloadviewer/Messages.sh <span style="color: grey">(b95833b3b5cf7865e72ed6b46e8dcd7848c599e1)</span></li>
<li>applets/systemloadviewer/TODO <span style="color: grey">(210dcd76f02b2a8f62e2e7339d089c545a4fb112)</span></li>
<li>applets/systemloadviewer/coloursconfig.ui <span style="color: grey">(70a08afbaa204bb78865a545965210f3e2dfe42a)</span></li>
<li>applets/systemloadviewer/generalconfig.ui <span style="color: grey">(2ae6d6540a12203e73bab5ca930da751f94bde22)</span></li>
<li>applets/systemloadviewer/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/BarMonitor.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/CircularMonitor.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/ColorPicker.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/GeneralSettings.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/plasma-applet-systemloadviewer.desktop <span style="color: grey">(9324d4216e716b2156f5f084c8b4782a6dd84806)</span></li>
<li>applets/systemloadviewer/systemloadviewer.h <span style="color: grey">(9bbcf2305ef47dd8883600002a9b65954ba65a74)</span></li>
<li>applets/systemloadviewer/systemloadviewer.cpp <span style="color: grey">(bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119927/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>