<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119860/">https://git.reviewboard.kde.org/r/119860/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Pier Luigi Fiorini.</div>
<div>By Marco Martin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">add the possibility to not have backgrounds in dialogs.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
one ting i don't like that much is the fact that it pretty much forces to either having perfect rectangular windows or to have composite for correct looks, but that will be probably less important.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
One thing that should be paid attention is that with no background is not supported the kwin-side shadow, as well no blur as well, since we don't have info for the shape, tough if needed in the future blur with just the full rectangular shape may be added as a new flag in backgroundhints, those possibilities of expansion is one reason it's an enum not a bool.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The use case for it is for custom dialogs in Maui, and since Dialog already manages the million edge cases of sizing and positioning that we had to fix, the least painful route i think is to use them with the background disabled.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
the framesvgitem is still there, but not having a svg loaded shouldn't take memory for images neither in heap nor gpu (probably would be good as well to set the flag itemhasnocontents on framesvgitem if imagepath is invalid, to be really sure it will never even try to upload any texture)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/dialog.h <span style="color: grey">(27b3b5a)</span></li>
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(64fb4a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119860/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>