<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119813/">https://git.reviewboard.kde.org/r/119813/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 17th, 2014, 2:36 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good, but: I'm aware of at least one downstream that would like to hide activities support from plasmashell for complexity reasons. Is there a way to disable activities support, and does it have an API we could use to conditionally hide the option in Folder?</p></pre>
</blockquote>
<p>On August 18th, 2014, 9:32 a.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is no way to disable activities. At least, not a supported way.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">do</em> sometimes test a few things without the activity manager running, but it was decided at one point (a long time ago) that we will not be supporting that setup in any manner.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only component that is always guaranteed to work without activities is kwin, because it needs to work with other environments beside Plasma.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From my point of view, if a distribution wants something like that, they need to be prepared to maintain their own patches which I don't think is very manageable in the long-run.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">interestingly enough, there still is a hidden checkbox in the activities kcm for disabling the system, but it was voted out as soon as I created it. It has absolutely no effect now.</li>
</ul></pre>
</blockquote>
<p>On August 18th, 2014, 10:23 a.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From my point of view, if a distribution wants something like that, they need to be prepared to maintain their own patches which I don't think is very manageable in the long-run.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree, having them fork the code downstream all over the place is pretty ugly. So the only recourse is to leave this patch out for now then.</p></pre>
</blockquote>
<p>On August 18th, 2014, 10:29 a.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem with leaving the patch out is that it is a regression compared to 4.1x (pre-baloo).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And if we do it like this, no new feature (at least, activity-related) will ever get in.</p></pre>
</blockquote>
<p>On August 18th, 2014, 10:52 a.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I actually feel really, really uncomfortable taking a firm stance here, because I can see both sides.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Making Activities optional can inhibit its uptake, preventing the implementation of functionality that relies on them being there, and so possibly functionality that justifies their existence. This is slightly similar to the old "Nepomuk on by default" debate.</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OTOH Plasma does claim to care about being a framework for downstreams to customize or implement new interfaces, and requiring forking+patching isn't supporting that cleanly. That some downstreams may want to offer interfaces that don't use Activities is legitimate. There's also value in the "if downstreams are going to do it anyway, we might as well maintain it upstream" stance that's popular through much FOSS. We've also intentionally modularized and decoupled a lot of things before as good engineering practice.</p>
</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only compromise I can come up with is not to make the "Disable activities" knob visible in the UI, but make it a ISV-level config option somewhere, or even a build-time option. A precedent: Some downstreams don't like the Desktop Toolbox. In Plasma 5 we provide a clean way to hide it, you can just put the .desktop file for the package in your distro profile overlay and add Hidden=true. Something like this for Activities might be a good idea - perhaps as simple as not autostarting the daemon and having the UI adapt to it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course we could also put an ISV-level option into Folder, i.e. have a UseActivities config key distros can set to false via desktop scripting and hide the option. But this has the downside of reimplementing it in every widget instead of having something central.</p></pre>
</blockquote>
<p>On August 18th, 2014, 10:53 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">note that not using activities is different to not having the daemon running or having the linking database active.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
not offering an activity switcher is one thing not having the daemon running will break things, no ways around it.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
If is really needed to not have it, the config ui can check if the daemon is not running not show the option, that may be a solution.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
"expect bug" is a constant tough</p></pre>
</blockquote>
<p>On August 18th, 2014, 1:13 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Another option is to put an option in defaults of the shell package (or look&feel?) on wether those options should be visible or not</p></pre>
</blockquote>
<p>On August 18th, 2014, 1:18 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Marco: Hmm, that sounds cool. How would that look like from a code POV, i.e. how exactly would Folder adapt to the LNF option?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">would have to be accessed by the c++ part..<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
that may mean also that i'll finally be forced to make the lookandfeelaccess class finally available in a library somewhere (what that class does is exposing a filePath() method to take files from the l&f package performing a fallback to the default one when the configured l&f package doesn't provide a certain file).<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
As first thing there may be just an hidden option.. could also be cool having a set of default configs for applets (as soon as created) either in the shell or l&f package, I'm not too sure how i would do that tough</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On August 17th, 2014, 2:32 p.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2014, 2:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is port of the feature that the folder view had before baloo replaced nepomuk - the configuration option to show the files that are linked to the current activity (activities:/current/).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It requires the latest master of kactivities which ship with the new kio implementation.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/folder/package/contents/ui/ConfigLocation.qml <span style="color: grey">(dc97e81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119813/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>