<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119814/">https://git.reviewboard.kde.org/r/119814/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Martin Gräßlin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[ksld] ScreenLocker inhibits sleep on logind</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When the system is going to sleep we want to ensure that the screen gets<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
locked before the system goes to sleep. Logind provides the inhibitor<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
locks which can be used for this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If logind is available ksld gains an inhibitor lock for sleep when the<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
screen is unlocked. As soon as the screen gets locked the inhibitor lock<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
is released. In addition it connects to the prepareForSleep signal by<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
logind and locks the screen.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The solution needs to be extended to have a config option whether the<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
screen should be locked on sleep. Currently this is provided by<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
powerdevil. Also the solution can only work properly if power devil uses<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
logind's sleep dbus interface.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[ksld] Don't block till the greeter is started</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We only want to ensure that the greeter gets started. There is no<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
need to block for that. Instead we can connect to the error signal<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
and unlock in case the greeter failed to start.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Alex: what do you think is the best solution for handling the "lock screen on resume" config option? My idea would be to move it to screen locker and expose the value through DBus, so that powerdevil can still read it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/logind.h <span style="color: grey">(a335ddc2f6f55b071f824f9da94652a4dd70c483)</span></li>
<li>ksmserver/screenlocker/logind.cpp <span style="color: grey">(dcfc7f321b3cf29ef68aac8006aa37f5e4e00956)</span></li>
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(5378a10df2be70cee95b5612c23046eae639f610)</span></li>
<li>ksmserver/screenlocker/autotests/CMakeLists.txt <span style="color: grey">(4bff1c6b1d8fc360197c422f8d036dff3eae5efe)</span></li>
<li>ksmserver/screenlocker/ksldapp.h <span style="color: grey">(095424c9845c134aa156917aeb6c8ddf31e8d25a)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(04c7db366722f61dd87407d557ccf7d04ce83bcc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>