<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119799/">https://git.reviewboard.kde.org/r/119799/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks Ivan! The "load actions asynchronously after the menu is hovered" approach is good, and the implementation looks fine to me. I went through the code and have not found any possible problems so far.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So unless anyone else sees a problem, I would say go ahead and ship it! Thanks for your work on this.</p></pre>
<br />
<p>- Frank Reininghaus</p>
<br />
<p>On August 15th, 2014, 8:42 a.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Dolphin, Plasma and Frank Reininghaus.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2014, 8:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New version of the file item plugin for the post nepomuk era and kf5.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The behaviour is changed compared to the previous one:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- At first, it shows a submenu (named 'Activities') that contains the 'Loading...' text<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- When the popup is requested to be shown (hovered signal of the root action) it asynchronously loads the sub-actions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is much faster than the nepomuk-based one, and it does not display the 'Loading...' item to the user at all.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested also with artificial slowing down with sleeps.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Tested also when the activity manager is not running.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/workspace/CMakeLists.txt <span style="color: grey">(bd4e636)</span></li>
<li>src/workspace/fileitemplugin/CMakeLists.txt <span style="color: grey">(d835aec)</span></li>
<li>src/workspace/fileitemplugin/FileItemLinkingPlugin.h <span style="color: grey">(ef7ad3b)</span></li>
<li>src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp <span style="color: grey">(5bcc141)</span></li>
<li>src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h <span style="color: grey">(6fb9b13)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119799/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>