<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119764/">https://git.reviewboard.kde.org/r/119764/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Fuminobu TAKEYAMA.</div>
<p style="color: grey;"><i>Updated 8月 14, 2014, 1:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=105797">105797</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix kcontrol/fonts saves fontconfig settings when it is opened. Add "System default" to each config. It removes a corresponding fontconfig entry made by this module. "System default" is now default values for sub-pixel rendering and hinting.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Selecting "System default" also reverts Xft configs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 105797</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove ~/.fonts.conf and ~/.config/fontconfig/*</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Open the font setting module and ensure that<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
~/.config/fontconfig/fonts.conf is not created before "Apply"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If "System Settings" are selected for "Use anti-aliasing" then<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
~/.config/fontconfig/fonts.conf (the name depends on environment)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
does not contains the following entries:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- rgba<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- hinting<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- hintstyle<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- antialias</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Enable antialiasing and set hinting style "None". The fontconfig file should contains:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<match target="font"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<edit mode="assign" name="hinting"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<bool>false</bool><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</edit><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</match><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<match target="font"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<edit mode="assign" name="hintstyle"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<const>hintnone</const><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</edit><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</match><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<match target="font"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<edit mode="assign" name="antialias"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<bool>true</bool><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</edit><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</match></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ xrdb -q | grep hint<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
should return empty</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Then revert hinting style to "System default". The file should not contains:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- hinting<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- hintstyle</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changing sub-pixel rendering to "None" adds:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<match target="font"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<edit mode="assign" name="rgba"><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<const>none</const><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</edit><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</match><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
to the file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ xrdb -q | grep hint<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
now returns:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Xft.hinting: 0<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Xft.hintstyle: hintnone</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/fonts/kxftconfig.h <span style="color: grey">(9efa9f5857ee81881916936b5036f79d3bb329c2)</span></li>
<li>kcms/fonts/kxftconfig.cpp <span style="color: grey">(6f3465f1cbc7b5231c11a6be40ee3c4ea96bb94e)</span></li>
<li>kcms/fonts/fonts.cpp <span style="color: grey">(1b5175eceb44ab93b642e02daca3e8a3a758a389)</span></li>
<li>kcms/fonts/fonts.h <span style="color: grey">(5b9f5d895cdfbf385f06994c182a83ae3722c2e1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119764/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>