<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119660/">https://git.reviewboard.kde.org/r/119660/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 8th, 2014, 11:02 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119660/diff/1/?file=302082#file302082line2" style="color: black; font-weight: bold; text-decoration: underline;">activeshellpackage/package/contents/explorer/CommonDelegate.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright 2011 Marco Martin <mart@kde.org></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">did you write this or Marco?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank you for your review and for pointed those issues out.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I pushed before i see your review.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I have push a new commit which is solving this issues.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As it regards the copyright, this file is actually a port from<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
the Plasma Active 1, this is why i left the copyright.</p></pre>
<br />
<p>- Antonis</p>
<br />
<p>On August 8th, 2014, 11:07 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2014, 11:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds Baloo support to Widget Explorer.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Also the the active containment is now able to load the resources from the kactivitymanager,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
The ones which we added from the Widget Explorer using the Baloo as a resource indexer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeshellpackage/package/contents/explorer/CommonDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeshellpackage/package/contents/explorer/WidgetExplorer.qml <span style="color: grey">(5073e71)</span></li>
<li>components/mobilecomponents/CMakeLists.txt <span style="color: grey">(879c2eb)</span></li>
<li>components/mobilecomponents/ResourceDelegate.qml <span style="color: grey">(67ceb67)</span></li>
<li>components/mobilecomponents/applicationlistmodel.h <span style="color: grey">(7107448)</span></li>
<li>components/mobilecomponents/applicationlistmodel.cpp <span style="color: grey">(451d4f8)</span></li>
<li>components/mobilecomponents/resourcedelegates/FileDataObject/Item.qml <span style="color: grey">(2fa6575)</span></li>
<li>components/mobilecomponents/resourcedelegates/FileDataObject/ItemHorizontal.qml <span style="color: grey">(7dfd003)</span></li>
<li>components/mobilecomponents/resourcedelegates/Image/Item.qml <span style="color: grey">(743069c)</span></li>
<li>components/mobilecomponents/resourcedelegates/Image/ItemHorizontal.qml <span style="color: grey">(51b9f27)</span></li>
<li>containments/activecontainment/contents/ui/ItemsList.qml <span style="color: grey">(c9d9919)</span></li>
<li>containments/activecontainment/contents/ui/ItemsListGroup.qml <span style="color: grey">(9655b31)</span></li>
<li>containments/activecontainment/contents/ui/main.qml <span style="color: grey">(4d2ba6d)</span></li>
<li>activeshellpackage/package/contents/explorer/AppletDelegate.qml <span style="color: grey">(9afdd52)</span></li>
<li>activeshellpackage/package/contents/explorer/CommonBrowser.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119660/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/43b31420-6562-4f92-9cb3-b1ff8b503af4__widgets.png">Widgets</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/bf509e3c-2272-48af-a159-2dad86582a29__applications.png">applications</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/e90bf903-5393-4e16-84c0-07bfb2622db4__documents.png">documents</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>