<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119670/">https://git.reviewboard.kde.org/r/119670/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On agosto 8th, 2014, 4:49 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119670/diff/1/?file=302571#file302571line29" style="color: black; font-weight: bold; text-decoration: underline;">applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">Plasmoid.compactRepresentation:</span> <span class="nx">Plasmoid</span><span class="p">.</span><span class="nx">fullRepresentation</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I /think/ we can just set a preferred representation, or a switching size of 0,0<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Otherwise we're potentially creating two instances of exactly the same component which would be a bit rubbish.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">those cases are what preferredRepresentation is for, I would go for that</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On agosto 8th, 2014, 4:24 p.m. UTC, Martin Yrjölä wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Yrjölä.</div>
<p style="color: grey;"><i>Updated Ago. 8, 2014, 4:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initial port of systemloadviewer</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This only includes basic functionality. I'm planning on adding at least:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Color settings<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Gradients!<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Horizontal bar support</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img alt="Screenshot" src="http://i.imgur.com/lB1d33s.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(661ecb421419f6cae8551924f107346787740aa9)</span></li>
<li>applets/systemloadviewer/CMakeLists.txt <span style="color: grey">(6de867aa63e5102a5085667f8106ec09da2c4968)</span></li>
<li>applets/systemloadviewer/Messages.sh <span style="color: grey">(b95833b3b5cf7865e72ed6b46e8dcd7848c599e1)</span></li>
<li>applets/systemloadviewer/TODO <span style="color: grey">(210dcd76f02b2a8f62e2e7339d089c545a4fb112)</span></li>
<li>applets/systemloadviewer/coloursconfig.ui <span style="color: grey">(70a08afbaa204bb78865a545965210f3e2dfe42a)</span></li>
<li>applets/systemloadviewer/generalconfig.ui <span style="color: grey">(2ae6d6540a12203e73bab5ca930da751f94bde22)</span></li>
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/plasma-applet-systemloadviewer.desktop <span style="color: grey">(9324d4216e716b2156f5f084c8b4782a6dd84806)</span></li>
<li>applets/systemloadviewer/systemloadviewer.h <span style="color: grey">(9bbcf2305ef47dd8883600002a9b65954ba65a74)</span></li>
<li>applets/systemloadviewer/systemloadviewer.cpp <span style="color: grey">(bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119670/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>