<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119451/">https://git.reviewboard.kde.org/r/119451/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2014, 12:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is still nowhere near final mergeability, but rather a request for comments for early stages ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, what does an application that uses stuff from l&f needs?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> open the proper l&f package, as configured<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> fetch files from it<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> use files of the default one if the provided one is incomplete<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> monitor for theme changes and if necessary reload the qml<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* some applications may even want to have an optional local config that overrides it, like the splash, but is out of scope of a central management</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the branch uses a little class that does all of the above (minus the last point) and uses it for now in the splash screen<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
For now it would just be statically linked into users, since they should be all in plasma-framework for now (of course not optimal)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">maybe</em> is stuff for libplasmaquick, but that library since locks a release of p-f with the same release of users of it, should probably me made public or else, so I'm a bit hesitant to add further stuff into it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c95eee9)</span></li>
<li>kcms/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/kcm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/kcm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/kcm_splashscreen.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/CMakeLists.txt <span style="color: grey">(2eb3671)</span></li>
<li>krunner/view.cpp <span style="color: grey">(21e66b2)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: grey">(49870fb)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: grey">(4837017)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(bb8a2bd)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg <span style="color: grey">(5480022)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(ccf6dd9)</span></li>
<li>ksmserver/tests/CMakeLists.txt <span style="color: grey">(79e942e)</span></li>
<li>ksplash/ksplashqml/CMakeLists.txt <span style="color: grey">(16c58a0)</span></li>
<li>ksplash/ksplashqml/SplashWindow.cpp <span style="color: grey">(23603f5)</span></li>
<li>ksplash/ksplashqml/shellpluginloader.h <span style="color: grey">(9c0f624)</span></li>
<li>lookandfeel/contents/defaults <span style="color: grey">(8b58863)</span></li>
<li>lookandfeel/contents/splash/screenshot.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel/metadata.desktop <span style="color: grey">(fbb4858)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeelaccess/shellpluginloader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(529e543)</span></li>
<li>shell/osd.cpp <span style="color: grey">(0e1adcc)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(1d92cf8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119451/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/2372f956-e086-4345-b89c-aca056b420f9__snapshot3.png">snapshot3.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>