<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119557/">https://git.reviewboard.kde.org/r/119557/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 1st, 2014, 4:28 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nope.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You're now listing plugins instead of listing categories.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ook, but this gives a couple of problems<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Only giving possibility of enabling and disabling categories, altough it kinda makes sense, makes it hard to respect the runner metadata on wether the plugin should be loaded by default or not. This is important because internet accessing runners should always be disabled by default. they may be all forced in one same category and have that disabled by default, but would be hard to enforce and for sure i still need distiction (i want to enable wikipedia, not amazon;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The second issue is for configuration of individual runners: some runners expose a configuration ui, and I don't want to lose that option: some configs are maybe less necessary (mostly are trigger words) some look very sensible and i want to keep them, like the media player control one.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">one solution may be to show the config button in the category if there is only plugin in the category and that plugin offers a configuration ui.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
It still doesn't cover the case of categories with more plugins, but better than nothing</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On August 1st, 2014, 1 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2014, 1 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there is a standard widget to enable or disable plugins used around: kpluginselector.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
this is needed also to access the about dialog of runners (maybe not 100% needed) and the config dialog some runners have (that's absolutely needed)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
graphically looks similar, just a bit more detailed (displays comments from the metadata files as well)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">note there is still a bug this uncovered before it can be merged (probably the reason it wasn't used before) the scrollbars are always hidden right now.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
that's a problem in kcategorizedview due to a workaround of an old Qt4 bug<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
update: the scrollbars are now fixed in kcategorizedview</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/runners/kcm.h <span style="color: grey">(0458430879964a10b2a15ff6660919874b7a5c3d)</span></li>
<li>kcms/runners/kcm.cpp <span style="color: grey">(0de07fbd73f692acb7b68efa665ba72dc8eddc5b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119557/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/be11d3fa-5de4-496b-a79e-450bd78318e6__snapshot4.png">snapshot4.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>