<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/107868/">https://git.reviewboard.kde.org/r/107868/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Jekyll, ping?</p></pre>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On December 31st, 2012, 7:12 p.m. UTC, Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 7:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=188494">188494</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What the current konquerorsessions plugin does is eventually calling "konqueror --profile xyz", so it is really for the profile feature of konqueror, not the session feature of konqueoror.
The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: grey">(bb4b491)</span></li>
<li>runners/konquerorprofiles/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorprofiles.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorprofiles.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorprofiles.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorsessions/CMakeLists.txt <span style="color: grey">(be2ea9d)</span></li>
<li>runners/konquerorsessions/Messages.sh <span style="color: grey">(0720e1e)</span></li>
<li>runners/konquerorsessions/konquerorsessions.cpp <span style="color: grey">(f2e437a)</span></li>
<li>runners/konquerorsessions/konquerorsessions.desktop <span style="color: grey">(df81780)</span></li>
<li>runners/konquerorsessions/konquerorsessions.h <span style="color: grey">(957f976)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/107868/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>