<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/104603/">https://git.reviewboard.kde.org/r/104603/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated July 29, 2014, 9:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265456">265456</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=295410">295410</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Closes: http://bugs.kde.org/show_bug.cgi?id=265456
Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410
"On screen display" notification when changing activities.
Displays the user icon and the name.
It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand.
This could be as well implemented on KWin, but i did as a kamd plugin for fun :P.
For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed activities and it works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>service/plugins/CMakeLists.txt <span style="color: grey">(3e965c0a201a7eee2c9868fcf163cf55af636858)</span></li>
<li>service/plugins/activitychangedosd/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangeditem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangeditem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosd.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosd.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosdplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosdplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/104603/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="https://git.reviewboard.kde.org/r/104603/s/531/"><img src="https://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/without_kwin_effects_400x100.jpeg" style="border: 1px black solid;" alt="without kwin effects" /></a>
<a href="https://git.reviewboard.kde.org/r/104603/s/532/"><img src="https://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/with_kwin_effects_400x100.jpeg" style="border: 1px black solid;" alt="with kwin effects" /></a>
<a href="https://git.reviewboard.kde.org/r/104603/s/533/"><img src="https://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/after_kwin_effects_disabled_400x100.jpeg" style="border: 1px black solid;" alt="after kwin effects disabledd (possible bug)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>