<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119250/">https://git.reviewboard.kde.org/r/119250/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 for this new backend.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other than already mentioned feedback, few things which need to be fixed are:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
1. When I click on button "Add event or trip", later I press escape/back and return back without actually cretaing any event. Now, if I again click on button "Add event or trip", it doesn't lead me to new page which allows user to create a new event. Even, edit button also doesn't work.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
2. Suppose, I have an event name "foo" and I browse into it. Now, I press "edit" button in order to edit event. Now, I changed my event "foo" to "bar". I would expect that my existing event foo should be renamed to bar, but here a new event gets created with name bar and foo also exist.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
3. When I edit an existing event with new date and click save, it still shows me images with previous saved date. To see images with modified date, I have to go back to folder and then it displays images with modified time.</p></pre>
<br />
<p>- Sinny Kumari</p>
<br />
<p>On July 12th, 2014, 6:13 p.m. UTC, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated July 12, 2014, 6:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I got this idea on a recent trip that usually a family would have a device where they store their trips/events photos on. Easier than tagging everything, what if you could just say "Hey, I went to Kashmir during 5 April to 14 April 2014" and voila!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This backend implements this idea in a (hopefully) easy-to-use way. I'll love to hear some feedback around this :)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems to work as expected, I will be attaching screenshots.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/CMakeLists.txt <span style="color: grey">(ae56603)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/backendsmodel.cpp <span style="color: grey">(2823fb6)</span></li>
<li>libs/mediacenter/filtermediamodel.h <span style="color: grey">(b8272f6)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventsbackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/metadatabackends/eventsbackend/eventsmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119250/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png">Showing events</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png">Showing photos from an event</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png">Editing dates of an existing event</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>