<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119219/">https://git.reviewboard.kde.org/r/119219/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 10th, 2014, 6:36 p.m. UTC, <b>Shantanu Tushar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My only problem with this is that its inconsistent with the Up/Down arrow key combination that we have in MediaPlayer. Also, you can't make the player also use Ctrl+Arrow keys because then a remote control won't work.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I'd suggest just making sure that the standard media keys work (play,pause etc) so that people can, for example, pause stuff when they get a phone call. To control the volume they can always press Esc and Up/Down.</p></pre>
</blockquote>
<p>On July 10th, 2014, 6:53 p.m. UTC, <b>R.Harish Navnit</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is it inconsistent ? I mean I'm able to use both(just the arrow keys and the combination). I've no idea of how a remote control would affect things so I don't know what that would require. <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I think the standard media keys do work. Yes, you can play/pause, no problems there. but are you suggesting that I use the combination "Esc + Up/Down" ? Well, I think that's inconsistent since the Esc key is being used as a shortcut to go to the previous screen. However, we do have the backspace key doing the same. I could change that if that's what you mean ? </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">P.S: I'm not sure if I've got what you're trying to convey. Is what I mentioned above right ?</p></pre>
</blockquote>
<p>On July 11th, 2014, 3 a.m. UTC, <b>Shantanu Tushar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Its inconsistent because the player needs only Up/Down (try it) but this one needs Ctrl as well (ideally you'd want the same shortcuts everywhere). Remote control concept is simple, every action should be possible use arrow keys, enter, esc. I meant you can press Esc from the home screen to go to the player, and then Up/Down to control the volume.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, the player volume can be controlled using the arrow keys, but they won't work when you're not in the player screen. The user can get away if he's in the home screen, but if the user was, let's say browsing through his pictures collection then pressing the Esc key is not really a good choice(3/4 presses of Esc key would take you to the player and only then would pressing the arrow key work), isn't that inconvenient ? </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We can have the same shortcuts everywhere(merely arrows won't work, since they're used for navigation in the homescreen etc), we could have a combination for the same, if not "ctrl + arrows", how about using shift ? Do you have any suggestions ?</p></pre>
<br />
<p>- R.Harish </p>
<br />
<p>On July 10th, 2014, 6:16 p.m. UTC, R.Harish Navnit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By R.Harish Navnit.</div>
<p style="color: grey;"><i>Updated July 10, 2014, 6:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">AFAIK, volume of a playing media cannot be controlled from the HomeScreen. This patch enables increasing and decreasing the volume using the combination of "Ctrl + Up/Down" keys.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use the "ctrl + up/down" keys to increase/decrease the volume of the current playing media. seems to work fine. </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: grey">(15c9cee7f86573939ac92872fb2201d944e0589f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119219/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>