<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119199/">https://git.reviewboard.kde.org/r/119199/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">may be interesting.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
since p-f is already released, pushing now would be in 5.1, and that's fine</p></pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On July 9th, 2014, 3:41 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated July 9, 2014, 3:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since the tool in davidedmundson/plasmoidloader was discarded, I've been thinking we need a way to tell how things are run in the plasma shell. The argument was that we need to run the plasmoids in a containment, so escentially the only way to get it is doing it within the plasmashell.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What I did here is to create a small class that keeps track of an object the changes in the properties and relates them to a point in time. This way we can see how things change and react to each other. Then, this information is outputted in a json file to analyze.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Take this review request as a request for comments, there's many things we can add there.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Runs fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here I'm attaching an example that portraits how the pager plasmoid changes status many times for no apparent reason and how I'm not ever getting the isUiReady(true).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/private/containment_p.cpp <span style="color: grey">(6a3b09c)</span></li>
<li>src/plasma/private/timetracker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/private/timetracker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/applet.h <span style="color: grey">(6effcc7)</span></li>
<li>src/plasma/containment.h <span style="color: grey">(c3907b0)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(2f680bf)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(3801857)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119199/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/09/8e3bb455-9c5e-48fd-8471-f2726e6ed6af__debug-apol.json">example</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>