<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119193/">https://git.reviewboard.kde.org/r/119193/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm just looking at the list of issues, could you maybe look at the codebases for Kicker (Application Menu) and Folder for inspiration? Kicker has a application model as well (relevant for your KServiceTypeTrader problem) and Folder is an icon view that has to solve mapping mouse coordinates to the view's content item (your "launching wrong index" problem). Always good to look at examples that solve similar problems already :).</p></pre>
<br />
<p>- Eike Hein</p>
<br />
<p>On July 9th, 2014, 11:28 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 9, 2014, 11:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The new launcher supports the following:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">it can show the applications</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">it can open an application.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Issues</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The IconGrid is returning a wrong index, so we are not opening the application, in which we clicked.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The IconGrid scrolling seems broken.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The TextField component doesn't get the correct focus.(open a kate in the background, go into the launcher, the input goes to kate, not to the TextField)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The KServiceTypeTrader::self()->query("Application"), returns back plugins which they are not applications.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeshellpackage/package/contents/views/Panel.qml <span style="color: grey">(a6b0c41)</span></li>
<li>activeshellpackage/package/contents/views/WindowList.qml <span style="color: grey">(d609214)</span></li>
<li>components/mobilecomponents/CMakeLists.txt <span style="color: grey">(69d6035)</span></li>
<li>components/mobilecomponents/applicationlistmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/mobilecomponents/applicationlistmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeshellpackage/package/contents/views/ApplicationList.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/mobilecomponents/mobilecomponentsplugin.cpp <span style="color: grey">(b344ab4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>