<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119176/">https://git.reviewboard.kde.org/r/119176/</a>
</td>
</tr>
</table>
<br />
<p>- Sebastian</p>
<br />
<p>On July 8th, 2014, 12:49 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated July 8, 2014, 12:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=336792">336792</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Since KUser doesn<span style="border: 1px solid #FF0000">'</span>t provide any change signalling, we<span style="border: 1px solid #FF0000">'</span>re watching both,
<span style="color: #666666">/</span>etc<span style="color: #666666">/</span>passwd (<span style="color: #008000; font-weight: bold">if</span> it exists) and the face icon path <span style="color: #008000; font-weight: bold">for</span> changes. The
latter is a pretty <span style="color: #008000; font-weight: bold">static</span> thing in KUser, so it<span style="border: 1px solid #FF0000">'</span>s safe to assume it
doesn<span style="border: 1px solid #FF0000">'</span>t change at runtime.
This makes updating the user<span style="border: 1px solid #FF0000">'</span>s full name and face image from
Personal Settings <span style="color: #666666">/</span> Password <span style="color: #666666">&</span> User Account update Kickoff<span style="border: 1px solid #FF0000">'</span>s header work
at runtime
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changed user information, watched Kickoff update automatically.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/core/kuserproxy.h <span style="color: grey">(ec77217)</span></li>
<li>applets/kickoff/core/kuserproxy.cpp <span style="color: grey">(713a182)</span></li>
<li>applets/kickoff/package/contents/ui/Header.qml <span style="color: grey">(75e2d97)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119176/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>