<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119163/">https://git.reviewboard.kde.org/r/119163/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 7th, 2014, 6:27 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119163/diff/1/?file=288432#file288432line140" style="color: black; font-weight: bold; text-decoration: underline;">src/declarativeimports/plasmacomponents/qml/ProgressBar.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">140</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">Accessible.role:</span> <span class="nx">Accessible</span><span class="p">.</span><span class="nx">ProgressBar</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This probably needs</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Accessible.name: value</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">otherwise a blind person can see it's a progress bar but no idea what the progress is.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Actually for a progress bar the screen reader already knows the type and we have code in QAccessibleQuickItem (qtdeclarative) that automatically checks for value, minimumValue, maximumValue properties. So I assume this already works by magic (I should probably add more documentation in Qt, but we were initially not 100% sure if we wanted to stick with this approach).</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 7th, 2014, 6:27 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119163/diff/1/?file=288436#file288436line330" style="color: black; font-weight: bold; text-decoration: underline;">src/declarativeimports/plasmacomponents/qml/Slider.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">330</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">Accessible.role:</span> <span class="nx">Accessible</span><span class="p">.</span><span class="nx">Slider</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This needs value + increment and decrement functions</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I will add the increment and decrement functions, good catch. Otherwise the same as for the ProgressBar applies.</p></pre>
<br />
<p>- Frederik</p>
<br />
<p>On July 7th, 2014, 5:27 p.m. UTC, Frederik Gladhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Sebastian Sauer and Jeremy Whiting.</div>
<div>By Frederik Gladhorn.</div>
<p style="color: grey;"><i>Updated July 7, 2014, 5:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds some accessibility properties to the plasma-framework controls. More work is needed, but these make many elements show up in accessibility helper tools.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: grey">(d67dda3)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/ToolBar.qml <span style="color: grey">(91b8f77)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/ToolButton.qml <span style="color: grey">(21afc21)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml <span style="color: grey">(8c6919e)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/ProgressBar.qml <span style="color: grey">(b85c100)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/RadioButton.qml <span style="color: grey">(769682b)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/ScrollBar.qml <span style="color: grey">(6b6f9dd)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/SectionScroller.qml <span style="color: grey">(9c6cc2e)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/Slider.qml <span style="color: grey">(8441eb5)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/Switch.qml <span style="color: grey">(60f179d)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/TabBar.qml <span style="color: grey">(809318a)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/TabButton.qml <span style="color: grey">(21302ef)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/TextArea.qml <span style="color: grey">(0ca6fe5)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/Button.qml <span style="color: grey">(186a39a)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/CommonDialog.qml <span style="color: grey">(75f0362)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/Label.qml <span style="color: grey">(033c41c)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/ListItem.qml <span style="color: grey">(4e6d5e7)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml <span style="color: grey">(74d81d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119163/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>