<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118891/">https://git.reviewboard.kde.org/r/118891/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm basically willing to follow the VDG's lead here in the end, although I think this approach has some problems:
- It's a fairly heavy deco for the containment case, which does make it feel a lot like a selection deco. This is reinforced by the fact that other file item delegates in the system (Dolphin, KFileDialog) behave similarly on selection.
- I can't quite make my mind up on whether it's a good thing or a bad thing that the deco on narrow single-line text items extends over the entire line width instead of bounding to the text. It's different from Dolphin/KFileDialog behavior, though.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118891/diff/2/?file=283777#file283777line121" style="color: black; font-weight: bold; text-decoration: underline;">containments/folder/package/contents/ui/ItemDelegate.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">121</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">leftMargin:</span> <span class="o">-</span><span class="mi">4</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you sure you wanted to hard-code pixel values here instead of using hidpi scaling-aware margins? units.smallSpacing is effectively 2px right now at 'standard DPI'.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118891/diff/2/?file=283777#file283777line129" style="color: black; font-weight: bold; text-decoration: underline;">containments/folder/package/contents/ui/ItemDelegate.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">color:</span> <span class="p">(</span><span class="nx">root</span><span class="p">.</span><span class="nx">isContainment</span> <span class="o">&&</span> <span class="nx">main</span><span class="p">.</span><span class="nx">GridView</span><span class="p">.</span><span class="nx">view</span><span class="p">.</span><span class="nx">isRootView</span><span class="p">)</span> <span class="o">?</span> <span class="k">theme.textColor :</span> <span class="nx">theme</span><span class="p">.</span><span class="nx">backgroundColor</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This causes a subtle brightly-colored rectangle in popups from the containment Folder View and in the widget case which I think looks fairly awkward to me. The dialog and widget backgrounds are designed to host theme.textColor already contrast-wise, so I think it'd be better to just not show this rectangle there.</pre>
</div>
<br />
<p>- Eike Hein</p>
<br />
<p>On June 23rd, 2014, 12:41 a.m. UTC, Andrew Lake wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andrew Lake.</div>
<p style="color: grey;"><i>Updated June 23, 2014, 12:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335070">335070</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070
The color of the text background is just the complement of the icon label text with a 0.6 opacity applied.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/folder/package/contents/ui/ConfigIcons.qml <span style="color: grey">(9f57900)</span></li>
<li>containments/folder/package/contents/ui/ItemDelegate.qml <span style="color: grey">(4f95f04)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118891/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png">Icon text background</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>