<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118891/">https://git.reviewboard.kde.org/r/118891/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 22nd, 2014, 11:29 p.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not a +1 or -1. Just my preference for this.
- No background (aka, fully transparent) when nothing is selected.
- Selected items should show the background as in your screenshot.
Just my preference though :)</pre>
</blockquote>
<p>On June 23rd, 2014, 12:07 a.m. UTC, <b>Andrew Lake</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change is for readability when nothing is selected. The normal icon selection background is unaffected.</pre>
</blockquote>
<p>On June 23rd, 2014, 9:23 a.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know, that's why i said:
"- No background (aka, fully transparent) when nothing is selected."
as my own preference. + it is consistent between other apps like dolphin which also doesn't have a default background color for deselected items.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What Andrew was trying to say is that this change is specifically designed to add a background that is guaranteed to contrast with the text, behind the text. Not showing it when the item is not selected breaks this guarantee and makes the change pointless.
Cf. https://bugs.kde.org/show_bug.cgi?id=335070 for an extended discussion of this.</pre>
<br />
<p>- Eike</p>
<br />
<p>On June 23rd, 2014, 12:41 a.m. UTC, Andrew Lake wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andrew Lake.</div>
<p style="color: grey;"><i>Updated June 23, 2014, 12:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335070">335070</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070
The color of the text background is just the complement of the icon label text with a 0.6 opacity applied.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/folder/package/contents/ui/ConfigIcons.qml <span style="color: grey">(9f57900)</span></li>
<li>containments/folder/package/contents/ui/ItemDelegate.qml <span style="color: grey">(4f95f04)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118891/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png">Icon text background</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>